Skip to content

Add support for midnight at the end of day #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jadchaar merged 1 commit into from
Nov 1, 2019
Merged

Add support for midnight at the end of day #705

jadchaar merged 1 commit into from
Nov 1, 2019

Conversation

@ceorcham
Copy link
Contributor

@ceorcham ceorcham commented Oct 31, 2019

Fix #703

@codecov-io
Copy link

codecov-io commented Oct 31, 2019 •
edited
Loading

Codecov Report

Merging #705 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #705   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1563   1573   +10     
  Branches      255    259    +4     
=====================================
+ Hits         1563   1573   +10
Impacted Files Coverage Δ
arrow/parser.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f063b5f...24e7a06. Read the comment docs.

@ceorcham ceorcham mentioned this pull request Oct 31, 2019
Closed
jadchaar
jadchaar requested changes Nov 1, 2019
View reviewed changes
Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! The PR looks great, but I have a few comments.

@ceorcham
Copy link
Contributor Author

ceorcham commented Nov 1, 2019

@jadchaar I force-pushed my branch to maintain the same commit message (I also rebased with master branch in the process)

jadchaar
jadchaar approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@systemcatch I think this is good to go, but I want to get another set of eyes just to make sure.

@systemcatch systemcatch self-requested a review November 1, 2019 14:25
systemcatch
systemcatch approved these changes Nov 1, 2019
View reviewed changes
Copy link
Collaborator

@systemcatch systemcatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jadchaar all good on my end.

@jadchaar jadchaar merged commit 6a5819b into arrow-py:master Nov 1, 2019
@ceorcham ceorcham deleted the bug-703 branch November 1, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jadchaar jadchaar jadchaar approved these changes

@systemcatch systemcatch systemcatch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HH token does not support the number 24, even though the documentation says it should (00 to 24)

4 participants

@ceorcham @codecov-io @jadchaar @systemcatch