Skip to content

Conversation

@andrewmwilson
Copy link
Contributor

@andrewmwilson andrewmwilson commented Jun 4, 2019

This is another regression in 0.14.0

Fixes: #600

@codecov-io
Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #601 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #601   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines        1501   1501           
  Branches      225    225           
=====================================
  Hits         1501   1501

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f77546d...421dfe8. Read the comment docs.

@jadchaar
Copy link
Member

jadchaar commented Jun 4, 2019

@andrewmwilson Looks good. Any difference between with codecs.open and with open("README.rst", "r", encoding="utf-8") as f:?

@jadchaar jadchaar self-requested a review June 4, 2019 02:27
@andrewmwilson
Copy link
Contributor Author

@jadchaar I don't think the encoding parameter exists in Python 2.

There is also io.open in Python 2.6+.

@jadchaar
Copy link
Member

jadchaar commented Jun 4, 2019

You are very right--codecs is fine! Also, mind adding encoding='utf-8' to the reading of init.py?

Then we can get this merged in.

@andrewmwilson
Copy link
Contributor Author

Done!

@jadchaar
Copy link
Member

jadchaar commented Jun 4, 2019

Thanks for the contribution @andrewmwilson. Apologies for these regressions; hopefully this will be the last one :).

@jadchaar jadchaar merged commit 95f2be6 into arrow-py:master Jun 4, 2019
Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setup.py needs to specify encoding when reading README.rst

3 participants