-
-
Notifications
You must be signed in to change notification settings - Fork 704
Always open README with utf-8 encoding #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always open README with utf-8 encoding #601
Conversation
Codecov Report
@@ Coverage Diff @@
## master #601 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 7 7
Lines 1501 1501
Branches 225 225
=====================================
Hits 1501 1501Continue to review full report at Codecov.
|
|
@andrewmwilson Looks good. Any difference between |
|
@jadchaar I don't think the There is also |
|
You are very right-- Then we can get this merged in. |
|
Done! |
|
Thanks for the contribution @andrewmwilson. Apologies for these regressions; hopefully this will be the last one :). |
jadchaar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is another regression in 0.14.0
Fixes: #600