Broken Python 2.x support in new release 0.11.0

[Gr1N]

Hello,

New release (0.11.0) is broken for Python 2.x users, below you can find steps to reproduce:

~/.virtualenvs/tmp-455f8c1518baad7 via tmp-455f8c1518baad7
➔ python --version
Python 2.7.14

~/.virtualenvs/tmp-455f8c1518baad7 via tmp-455f8c1518baad7
➔ pip install arrow
Collecting arrow
Collecting python-dateutil (from arrow)
  Using cached python_dateutil-2.6.1-py2.py3-none-any.whl
Collecting six>=1.5 (from python-dateutil->arrow)
  Using cached six-1.11.0-py2.py3-none-any.whl
Installing collected packages: six, python-dateutil, arrow
Successfully installed arrow-0.11.0 python-dateutil-2.6.1 six-1.11.0

~/.virtualenvs/tmp-455f8c1518baad7 via tmp-455f8c1518baad7
➔ python
Python 2.7.14 (default, Sep 25 2017, 09:53:22)
[GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.37)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import arrow
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/ng/.virtualenvs/tmp-455f8c1518baad7/lib/python2.7/site-packages/arrow/__init__.py", line 3, in <module>
    from .arrow import Arrow
  File "/Users/ng/.virtualenvs/tmp-455f8c1518baad7/lib/python2.7/site-packages/arrow/arrow.py", line 19, in <module>
    from arrow import util, locales, parser, formatter
  File "/Users/ng/.virtualenvs/tmp-455f8c1518baad7/lib/python2.7/site-packages/arrow/parser.py", line 12, in <module>
    from backports.functools_lru_cache import lru_cache  # pragma: no cover
ImportError: No module named backports.functools_lru_cache
>>>

Could you fix this please?

[GrimmiMeloni]

Yes, this is really bad. I spent the last 3 hours trying to get @platformio up and running again. Turns out, it runs against this error. @ivankravets are you already aware of this issue? I am pretty sure you will get tons of false bug reports, as this causes (yet another) Install Endless Loop in Atom....

[ivankravets]

@GrimmiMeloni I can't reproduce this issue with my default Python 2.7.10 on macOS. What are your OS and Python version?

[Gr1N]

And I found why all builds is green...

To run tests we need to install deps from requirements.txt:

build27:
	virtualenv local --python=python2.7
	local/bin/pip install -r requirements.txt

And as we can see requirements.txt contains backports.functools_lru_cache:

➔ cat requirements.txt
python-dateutil==2.6.0
nose==1.3.0
nose-cov==1.6
chai==1.1.1
sphinx==1.3.5
simplejson==3.6.5
backports.functools_lru_cache==1.2.1

But backports.functools_lru_cache is missing in setup.py...

[Gr1N]

I hope this patch should fix issue:

diff --git a/setup.py b/setup.py
index a48aa91..00c772f 100644
--- a/setup.py
+++ b/setup.py
@@ -37,7 +37,8 @@ setup(
     packages=['arrow'],
     zip_safe=False,
     install_requires=[
-        'python-dateutil'
+        'python-dateutil',
+        'backports.functools_lru_cache;python_version<"3"',
     ],
     test_suite="tests",
     classifiers=[

Tested on my local, everything works fine.

[Gr1N]

Same issue #491

[ivankravets]

@Gr1N You are right, this is a CRITICAL issue. @crsmithdev could you make a new release of "arrow" with adding a dependency to backports.functools_lru_cache?

Thanks!

[ivankravets]

'backports.functools_lru_cache;python_version<"3"'

@Gr1N The better is to check Python version and dynamically configure install_requires. Otherwise, we will have an issue with the old version of setuptools.

[Gr1N]

Do as you think is right, I just want to get a new package with fix :)

[ivankravets]

@GrimmiMeloni temporary fixed as extra deps for @platformio platformio/platformio-core@37a2cce

Please remove %HOME_DIR%/.platformio/penv folder and restart PlatformIO IDE. It should work now.

[ramonsaraiva]

Please check the PR i've created to address this issue, we need to push this asap.

[ramonsaraiva]

Fixed on https://pypi.python.org/pypi/arrow/0.12.0 - please upgrade arrow if you're using python 2.x and arrow 0.11.0

[Gr1N]

Thank you!