Repository navigation
Conversation
- src/config/site.config.ts: base path, canonical origin, author and social links, the article link, shared by vite.config.ts (build) and main.tsx (runtime) - src/config/commerce.config.ts: tax rate, free shipping threshold and cost, per-item quantity limits, currency conversion factors. ShippingPolicy, TaxPolicy, CartItem, and GoldSilverCopperFormatter read from it instead of hardcoding numbers, and their static fields are now readonly - src/config/storage.config.ts: which WelcomeSurveyStorage implementation is active, replacing three commented-out imports in a UI file with one line in a config file - src/config/analytics.config.ts: the Umami event-name taxonomy, replacing scattered string literals across ShoppingCart.tsx, WelcomeModal.tsx, and the home route - the Umami website id now lives in .env (VITE_UMAMI_WEBSITE_ID) and is interpolated into index.html's script tag and read by analytics.config.ts, one source of truth for both - public/404.html can't import a TS module, added a comment pointing at site.config.ts as the source it has to stay in sync with Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014BcGPRc3sgUJYKihGRXh5g
This was referenced Sep 1, 2026
Owner
Author
|
Folded into #17 (combined toolchain + bugfix PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4.
Summary
src/config/site.config.ts: base path, origin, author and social links, article link.Shared by
vite.config.tsat build time andmain.tsxat runtimesrc/config/commerce.config.ts: tax rate, free shipping threshold and cost, per-itemquantity limits, currency conversion factors.
ShippingPolicy,TaxPolicy,CartItem,and
GoldSilverCopperFormatterread from it, and their static fields are now readonlysrc/config/storage.config.ts: whichWelcomeSurveyStorageimplementation is active,replacing three commented-out imports in a UI file with one line in a config file
src/config/analytics.config.ts: the Umami event-name taxonomy, replacing scatteredstring literals across three files
.env, interpolated intoindex.htmland read byanalytics.config.ts, one source of truth for bothTest plan
pnpm typecheckpnpm checkpnpm build, confirmed the interpolated Umami id lands correctly indist/index.htmlpnpm test, same 4 pre-existing failures, unrelated, fixed next in the stack🤖 Generated with Claude Code
https://claude.ai/code/session_014BcGPRc3sgUJYKihGRXh5g