orangepi5-plus: u-boot: use mainline ATF; bump to v2026.01; drop funky CE config options#9261
Conversation
📝 WalkthroughWalkthroughBoard configuration for Orange Pi 5 Plus switched boot scenario to "tpl-blob-atf-mainline", removed SPI-specific variables, bumped mainline U-Boot/ATF from v2025.10 to v2026.01, replaced BL31 blob path with fixed Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I don't have a spare 5+ to test this. |
won't work with this, most likely. rkbin blob is required to sneakily remap an interrupt for vendor hdmirx (which is incompatible with mainline hdmirx). not specific to opi either. |
…y CE config options - also drop BOOT_SUPPORT_SPI & BOOT_SPI_RKSPI_LOADER as those are for vendor u-boot, not used here
944589e to
bc7457c
Compare
|
Can confirm, patch works for Orange Pi 5 Plus using BRANCH="current" (6.18.6) and BOARD="orangepi5-plus". |
|
✅ This PR has been reviewed and approved — all set for merge! |
|
Does hdmirx in mainline work already? I mean as mentioned this would sacrifice this feature when being on vendor kernel which, sadly, has still some relevance in certain scenarios. |
Yes, since 6.18: torvalds/linux@ccc7f16 - but only with mainline ATF. |
|
Either way, the point here is not hdmirx, but actually fixing the non-bootness problem reported by @Marsupilami23 (and confirmed fixed). |
|
right, then since confirmed working, lets do it |
EvilOlaf
left a comment
There was a problem hiding this comment.
There are a quite a bunch of other boards still using spl blobs. Should this be ajdusted to other boards too? Like rock5b, opi5 (without b or pro or plus or ultra or monsterxxl or whatever ridicoulos name comes up next)?
I suggest this:
this one I think checks all three. |
|
build breaks on jammy and noble |
Can't find jobs failing? care to share? |
|
Oh I see, this is vendor u-boot. I was under the impression that this board only had mainline u-boot, even for vendor branch. Let me check. |
|
@igorpecovnik fixed at #9287
I was wrong about this. This board still has vendor u-boot for the vendor branch. Vendor hdmirx should work as long as vendor u-boot actually boot the machine. For users: keep in mind mixing blobs is problematic (SPI vs eMMC vs SD). When trying to boot current/edge (specially from SD card), ensure you don't have a leftover vendor stuff in eMMC/SPI. |
Summary by CodeRabbit
Updates
Changes
✏️ Tip: You can customize this high-level summary in your review settings.