Add timeout on check wan address on motd#7297
Merged
igorpecovnik merged 3 commits intoarmbian:mainfrom Sep 25, 2024
Merged
Conversation
- Without this control it can cause a continuous loop until curl goes into timeout
Collaborator
|
Personally I don't understand why there is a need to get public IP for a system and show it in motd. But assuming its needed by others, why not just use |
nvollmar
reviewed
Sep 25, 2024
igorpecovnik
approved these changes
Sep 25, 2024
2 tasks
Dangku
pushed a commit
to BPI-SINOVOIP/armbian-build
that referenced
this pull request
Jan 16, 2025
* add timeout on get_wan_address
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a timeout on check the wan address
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
Checklist: