Add -hyperv suffix to REDI_VARIANT for Hyper-V images

[igorpecovnik]

Summary

• Set REDI_VARIANT to {variant}-hyperv for hyperv.zip* files
• Matches the pattern used for qcow2 cloud images

Problem

For Hyper-V cloud images, the REDI_URL was not including the -hyperv suffix, resulting in URLs like:

• https://dl.armbian.com/Uefi-arm64/Noble_cloud_minimal

Solution

Added an elif check for hyperv.zip* extensions to properly set REDI_VARIANT, now generating:

• https://dl.armbian.com/Uefi-arm64/Noble_cloud_minimal-hyperv

[coderabbitai]

Walkthrough

The shell script scripts/generate-armbian-images-json.sh has been modified to extend the extract_file_extension function to recognize and normalize HyperV cloud image names. When filenames contain ".hyperv.zip.", the function outputs "hyperv.zip."; when filenames end with ".hyperv.zip", it outputs "hyperv.zip". The REDI_VARIANT construction logic has also been updated to set the variant to "${VARIANT}-hyperv" when FILE_EXTENSION matches hyperv.zip* patterns, providing dedicated handling for HyperV image types alongside existing image-type special-casing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: adding a -hyperv suffix to REDI_VARIANT for Hyper-V images, which matches the primary objective of the pull request.
Description check	✅ Passed	The pull request description clearly relates to the changeset, describing the problem (missing -hyperv suffix in REDI_URL), the solution (adding elif check for hyperv.zip* extensions), and providing concrete examples of before/after behavior.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch hyperv-redi-url-fix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}