More explicit R1CS tests/examples #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pratyush
reviewed
Jan 15, 2022
Comment on lines
1100
to
1102
| let three = field_new!(Fr, "3"); | ||
| let five = field_new!(Fr, "5"); | ||
| let nine = field_new!(Fr, "9"); |
Pratyush
approved these changes
Jan 15, 2022
Member
Pratyush
left a comment
Pratyush
left a comment
There was a problem hiding this comment.
LGTM modulo the stylistic nit
Pratyush
approved these changes
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding more descriptive tests helps to understand how R1CS works inside arkworks.
In particular, in this PR I've "translated" the R1CS part of Vitalik's write up to use this library and construct the same matrices.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer