Skip to content

Conversation

@achimcc
Copy link

@achimcc achimcc commented Dec 7, 2022

Description

This PR moves the implementation of the functions multi_miller_loop and final_exponentiation in the Bls12 model from the Pairing trait into the Bls12Parameters trait. Here they serve as default implementations, which are then referenced in the Pairing implementation for Bls12.

This way we can overwrite the default implementations for both functions when we define model curves for the bls12 model. The motivation for this is like the one in #528 : we can provide our own implementations on platforms on which elliptic curve arithmetic is slow or for the case os specialized hardware.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@achimcc achimcc marked this pull request as ready for review December 9, 2022 16:29
@achimcc achimcc requested review from a team as code owners December 9, 2022 16:29
@achimcc achimcc requested review from mmagician and weikengchen and removed request for a team December 9, 2022 16:29
@Pratyush Pratyush changed the title Move multi_miller_loop and final_exponentiation into Bls12Parameters Move multi_miller_loop and final_exponentiation into Bls12Config Dec 9, 2022
@Pratyush Pratyush merged commit 47268f4 into arkworks-rs:master Dec 9, 2022
@achimcc achimcc deleted the pass-miller-loop-exp branch December 9, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants