Customizable serialization for `SWCurveConfig` and `TECurveConfig` by alexander-zw · Pull Request #467 · arkworks-rs/algebra

alexander-zw · 2022-09-04T00:29:59Z

Description

closes: #308

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (master)
Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
Wrote unit tests
Updated relevant documentation in the code
Added a relevant changelog entry to the Pending section in CHANGELOG.md
Re-reviewed Files changed in the GitHub PR explorer

alexander-zw · 2022-09-04T00:34:34Z

+        let zero = Self::BaseField::zero();
+        match compress {
+            Compress::Yes => zero.serialized_size_with_flags::<TEFlags>(),
+            Compress::No => zero.uncompressed_size() + zero.uncompressed_size(),


I changed this from x.uncompressed_size() + y.uncompressed_size() to zero.uncompressed_size() + zero.uncompressed_size(). Is there a difference? Aren't they all the same field? With this change this function is independent of the affine element.

The tests passed after this change, though I'm not sure how well serialize size is tested

It's the same right now, but if it's simpler we can keep the old behaviour.

The new behavior is simpler. In the new behavior the size doesn't depend on the curve element, in the old behavior it referenced the curve values. So should we keep the behavior in this PR right now?

Move serialization methods into curve config for SW and TE

8716632

alexander-zw requested a review from Pratyush September 4, 2022 00:29

alexander-zw self-assigned this Sep 4, 2022

Update changelog

5c1dde5