Skip to content

Fix deserialization for modulo with 64 shaving bits - #442

Merged
Pratyush merged 5 commits into
masterfrom
fix-shr
Jul 26, 2022
Merged

Fix deserialization for modulo with 64 shaving bits #442
Pratyush merged 5 commits into
masterfrom
fix-shr

Conversation

@weikengchen

@weikengchen weikengchen commented Jul 18, 2022

Copy link
Copy Markdown
Member

Description

In an application, I need to instantiate a field in which the modulus is 256 bits. In arkworks-rs, this field must use Fp320 instead of Fp256, and therefore the number of shaving bits is 64 bits.

However, this can cause an issue during deserialization.

This PR fixes this issue.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

N/A:

  • Wrote unit tests
  • Updated relevant documentation in the code

@Pratyush
Pratyush merged commit 046b3d1 into master Jul 26, 2022
@Pratyush
Pratyush deleted the fix-shr branch July 26, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants