Skip to content

Map-to-curve - #430

Merged
mmagician merged 76 commits into
arkworks-rs:masterfrom
mmagician:map-to-curve-tests
Jul 27, 2022
Merged

Map-to-curve#430
mmagician merged 76 commits into
arkworks-rs:masterfrom
mmagician:map-to-curve-tests

Conversation

@mmagician

Copy link
Copy Markdown
Member

Description

As a companion to hash-to-field, together these two modules constitute hash-to-curve, and are both compatible with the test suites from IETF draft v16 on hashing to curve.

Blocked by; For compatibility with tests suites, I changed the COFACTOR constant to match h_eff. We should first have a clear_cofactor method and call that instead, as presented in #420.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

mmagician and others added 30 commits February 16, 2022 16:32
Hashing to correct field in either G1 or G2.
Tests don't pass yet
Co-authored-by: drskalman <35698397+drskalman@users.noreply.github.com>
digest in hope to resolve the std dependancy
Not working yet - points not matching
instead of on the isogeny

Unify SWU and WB maps

Revert "Unify SWU and WB maps"

This reverts commit e8a78fd.

Expose ec and g1_iso items
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
@mmagician
mmagician marked this pull request as ready for review June 30, 2022 17:05
@mmagician
mmagician requested a review from Pratyush July 14, 2022 21:23
Comment thread test-curves/src/bls12_381/g1.rs
Comment thread test-curves/src/bls12_381/g1_swu_iso.rs Outdated
Comment thread test-curves/src/bls12_381/g2_swu_iso.rs Outdated
Comment thread test-curves/src/bls12_381/g2_swu_iso.rs Outdated
@mmagician
mmagician requested a review from Pratyush July 19, 2022 10:14
@mmagician
mmagician merged commit ffea2b8 into arkworks-rs:master Jul 27, 2022
@mmagician
mmagician deleted the map-to-curve-tests branch August 3, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants