Skip to content

Add GLVParameters trait definition - #301

Merged
weikengchen merged 12 commits into
arkworks-rs:masterfrom
zhenfeizhang:master
Sep 6, 2021
Merged

Add GLVParameters trait definition#301
weikengchen merged 12 commits into
arkworks-rs:masterfrom
zhenfeizhang:master

Conversation

@zhenfeizhang

@zhenfeizhang zhenfeizhang commented Jul 3, 2021

Copy link
Copy Markdown
Contributor

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work: This PR defines GLV parameters trait for ark-ec and will be useful in bandersnatch implementation
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

not related

  • Wrote unit tests

@zhenfeizhang

Copy link
Copy Markdown
Contributor Author

Note that this GLV parameters use a different set of definitions, and will not be compatible with a draft definition in #127 (which seems to be inactive)

Comment thread CHANGELOG.md Outdated
@Pratyush

Pratyush commented Jul 8, 2021

Copy link
Copy Markdown
Member

Hey @zhenfeizhang , thanks for the PR! I'll try to review this within the next few days!

Comment thread ec/src/glv.rs
@weikengchen weikengchen changed the title adding GLV parameters trait Add GLVParameters trait definition Sep 6, 2021
@weikengchen
weikengchen merged commit 344b27d into arkworks-rs:master Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants