Skip to content

Fix radix-2 serial FFT - #244

Merged
Pratyush merged 2 commits into
masterfrom
fix-realignment-logic
Mar 24, 2021
Merged

Fix radix-2 serial FFT#244
Pratyush merged 2 commits into
masterfrom
fix-realignment-logic

Conversation

@Pratyush

@Pratyush Pratyush commented Mar 24, 2021

Copy link
Copy Markdown
Member

Description

Fixes #243 cc @ValarDragon

This bug was introduced because CI unconditionally enables features = parallel

The fix is to move the realignment to the end of the loop, so that it doesn't occur in the first iteration at all, and we don't have to perform that check.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@Pratyush
Pratyush requested a review from ValarDragon March 24, 2021 10:42

@weikengchen weikengchen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Pratyush
Pratyush merged commit 932e6b7 into master Mar 24, 2021
@Pratyush
Pratyush deleted the fix-realignment-logic branch March 24, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cargo test fails wrt FFTs

2 participants