Fix the definition of PairingFriendlyCycle - #217
Merged
Conversation
Pratyush
reviewed
Feb 8, 2021
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
Pratyush
approved these changes
Feb 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current definition of PairingFriendlyCycle has a small problem that
Engine2::G2Affine = E2, which would not be able to represent the MNT4/6 cycle under the current representation (where G_1 resides the matching groups). This PR modifies the definition asEngine2::G1Affine = E2so that it works with the correct pairing representation of MNT4/6.closes: #216
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer