Skip to content

Update Directory.Build.props#65

Merged
arika0093 merged 1 commit intomainfrom
arika0093-patch-1
Jan 27, 2026
Merged

Update Directory.Build.props#65
arika0093 merged 1 commit intomainfrom
arika0093-patch-1

Conversation

@arika0093
Copy link
Owner

@arika0093 arika0093 commented Jan 27, 2026

Summary by CodeRabbit

  • Chores
    • Updated test infrastructure configuration with an additional dependency.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

📝 Walkthrough

Walkthrough

A NuGet package reference for GitHubActionsTestLogger version 3.0.1 was added to the test project configuration file.

Changes

Cohort / File(s) Summary
Test Configuration
tests/Directory.Build.props
Added PackageReference for GitHubActionsTestLogger v3.0.1 to ItemGroup

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A logger hops into our tests so bright,
GitHub Actions now sees what's right,
One line added, no fuss, no fight,
Our rabbit's werk brings testing light! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and generic, using only 'Update Directory.Build.props' without specifying what was updated or why. Consider a more descriptive title such as 'Add GitHubActionsTestLogger NuGet package to test dependencies' to clearly communicate the specific change.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

@arika0093 arika0093 enabled auto-merge (squash) January 27, 2026 14:19
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@tests/Directory.Build.props`:
- Line 9: Update the PackageReference for the GitHubActionsTestLogger so it
doesn't flow transitively: locate the PackageReference element with
Include="GitHubActionsTestLogger" and Version="3.0.1" in Directory.Build.props
and add the attribute PrivateAssets="all" to the element (i.e., set
PrivateAssets on the PackageReference for GitHubActionsTestLogger).

<IsTestProject>true</IsTestProject>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="GitHubActionsTestLogger" Version="3.0.1" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🌐 Web query:

GitHubActionsTestLogger NuGet package version 3.0.1 latest

💡 Result:

Yes—GitHubActionsTestLogger 3.0.1 is the latest stable release on NuGet, last updated Nov 24, 2025. [1][2]


🌐 Web query:

GitHubActionsTestLogger compatibility Microsoft.NET.Test.Sdk

💡 Result:

  • Minimum requirement (VSTest / dotnet test --logger GitHubActions): Your test project should reference Microsoft.NET.Test.Sdk >= 16.8.0; older versions may not work correctly with custom loggers like GitHubActionsTestLogger. [1]
  • Works with current 17.x (including 17.14.x): Microsoft.NET.Test.Sdk continues to be compatible broadly, but note the runner’s own .NET targeting changes below. [2]
  • If your test project targets net6.0: VS Test 17.14 moved to newer .NET versions; guidance is to pin Microsoft.NET.Test.Sdk to 17.13.0 (or upgrade the test project to net8.0+). [3]
  • If you’re using Microsoft.Testing.Platform (MTP) instead of VSTest: Newer GitHubActionsTestLogger versions advertise support for both VSTest and MTP. [4] (Historically, MTP didn’t parse --logger the same way, which is why older setups could fail.) [5]

Sources:
[1] NuGet readme for GitHubActionsTestLogger (versioned page showing the Microsoft.NET.Test.Sdk >= 16.8.0 requirement). (nuget.org)
[2] NuGet page for Microsoft.NET.Test.Sdk 17.14.1. (nuget.org)
[3] microsoft/vstest release notes (17.14: net6 projects should pin Microsoft.NET.Test.Sdk to 17.13.0). (github.com)
[4] NuGet page for GitHubActionsTestLogger 3.0.1 (“Extension for VSTest and Microsoft.Testing.Platform”). (nuget.org)
[5] GitHub issue discussing MTP not parsing --logger in older versions (context for compatibility problems). (github.com)

Citations:


🌐 Web query:

GitHubActionsTestLogger PrivateAssets all recommended test project

💡 Result:

For GitHubActionsTestLogger, the recommended way to reference it from a test project is to mark it as test-only so it doesn’t flow transitively to other projects/packages:

<ItemGroup>
  <PackageReference Include="GitHubActionsTestLogger" Version="3.0.1" PrivateAssets="all" />
</ItemGroup>

NuGet’s own snippet for this package also uses <PrivateAssets>all</PrivateAssets> (and sometimes an explicit IncludeAssets list) for the same reason: keep the logger available to the test project, but prevent it from becoming a transitive dependency of anything that references the test project. [1]

If you follow NuGet’s “full” form (as shown on older version pages), it looks like this:

<PackageReference Include="GitHubActionsTestLogger" Version="2.3.0">
  <PrivateAssets>all</PrivateAssets>
  <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>

That IncludeAssets is not redundant because it can exclude assets like compile (even when PrivateAssets=all). [2]

Source(s): NuGet package page for GitHubActionsTestLogger (shows the recommended PackageReference, including PrivateAssets and sometimes IncludeAssets) [1]; explanation of PrivateAssets vs IncludeAssets behavior [2].

References:
[1] NuGet Gallery – GitHubActionsTestLogger (latest) https://www.nuget.org/packages/GitHubActionsTestLogger
[2] Stack Overflow – “If a nuget specifies PrivateAssets=all why specify IncludeAssets?” https://stackoverflow.com/questions/73180516/if-a-nuget-specifies-privateassets-all-why-specify-includeassets


Add PrivateAssets="all" to isolate test logger from transitive dependencies.

The package reference should be updated to prevent the logger from flowing transitively:

Suggested change
<PackageReference Include="GitHubActionsTestLogger" Version="3.0.1" PrivateAssets="all" />
🤖 Prompt for AI Agents
In `@tests/Directory.Build.props` at line 9, Update the PackageReference for the
GitHubActionsTestLogger so it doesn't flow transitively: locate the
PackageReference element with Include="GitHubActionsTestLogger" and
Version="3.0.1" in Directory.Build.props and add the attribute
PrivateAssets="all" to the element (i.e., set PrivateAssets on the
PackageReference for GitHubActionsTestLogger).

@arika0093 arika0093 disabled auto-merge January 27, 2026 14:19
@arika0093 arika0093 merged commit 578b65b into main Jan 27, 2026
4 checks passed
@arika0093 arika0093 deleted the arika0093-patch-1 branch January 27, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant