cmd/atlas/internal/cmdapi: add command line flag for lock name #3475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our application we use single database and different schemas for each microservice. There are several reasons for using this kind of setup.
The migrate command used a fixed name for the migration lock (PG advisory lock). That caused issues in our application: one microservice running a lenghty migration caused all other microservices to be waiting for the lock to check and run their migrations.
To remedy the situation, this commit makes the lock name to be configurable using a command line flag. Condirered also making the locking to use schema name as lock name, but that might not be what other applications want. Introducing a separate command line flag for the lock name offers the most flexible solution.
The default behaviour is the same as before. If the lock name flag is not given, the old fixed name is used for lock.