SSA CFG: extract liveness counts data structure#16644
Merged
Conversation
clonker
force-pushed
the
ssa-cfg-stack-slot-liveness
branch
from
6a5af8a to
b490ba9
Compare
blishko
reviewed
Apr 28, 2026
Contributor
blishko
left a comment
blishko
left a comment
There was a problem hiding this comment.
Looks good!
There is just a comment that needs rephrasing and I have a small question about the difference of use sets.
clonker
force-pushed
the
ssa-cfg-stack-slot-liveness
branch
from
b490ba9 to
45c05a1
Compare
blishko
requested changes
Apr 28, 2026
clonker
force-pushed
the
ssa-cfg-stack-slot-liveness
branch
from
45c05a1 to
a75fb6b
Compare
blishko
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ssa::util::UseCountSetwhich, in effect, is the underlying datastructure of the liveness dataStackSlotLiveness, which is the same data but on stack slots. this will help the stack shuffler stay as decoupled as possible from the SSACFG post unification, as there, the value id no longer carries the type of operation it was emitted from