Skip to content

Conversation

@shota3506
Copy link
Contributor

@shota3506 shota3506 commented Oct 20, 2025

modernize go code with stdlib improvements by running modernize command

Motivation

#14943 (comment)
cc: @Joibel

Apply a subset of modernize autofixes before enabling the modernize analyzer in golangci-lint.
Limiting the categories helps reduce the diff size in this PR.

  • minmax
  • sortslice
  • mapsloop
  • fmtappendf
  • stringsseq
  • stringscutprefix

Modifications

Executed the following command to apply specific autofixes and format some comments:

go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -category=minmax,sortslice,mapsloop,fmtappendf,stringsseq,stringscutprefix -fix -test ./...

and format some comments

Verification

Documentation

Copy link
Member

@Joibel Joibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is good

@Joibel Joibel merged commit de8c12c into argoproj:main Oct 23, 2025
39 checks passed
ItielOlenick pushed a commit to ItielOlenick/argo-workflows that referenced this pull request Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants