feat: add counter metrics for mutexes and semaphores #14906
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to argoproj#14888 This commit adds counter metrics for mutexes and semaphores in the Argo Workflows telemetry system. Signed-off-by: jmeridth <[email protected]>
Signed-off-by: jmeridth <[email protected]>
- add/remove mutexes - add/remove semaphores Signed-off-by: jmeridth <[email protected]>
Signed-off-by: jmeridth <[email protected]>
jmeridth
force-pushed
the
jm_semaphore_mutex_counters
branch
from
5de7ee6 to
98bb09c
Compare
Track taken and released mutexes and semaphores as separate counters Signed-off-by: jmeridth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #14888
Motivation
This commit adds counter metrics for mutexes and semaphores in the Argo Workflows telemetry system so users can know if there are active locks or not.
Modifications
Verification
Documentation
make docs/metrics.md