fix: allow legacy name validation scheme for prometheus metrics #14879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Rodrigues <[email protected]>
Member
Author
|
/retest |
Joibel
requested changes
Oct 17, 2025
Co-authored-by: Alan Clucas <[email protected]> Signed-off-by: Eduardo Rodrigues <[email protected]>
Signed-off-by: Eduardo Rodrigues <[email protected]>
Joibel
requested changes
Oct 20, 2025
Member
Joibel
left a comment
Joibel
left a comment
There was a problem hiding this comment.
nit: I'm still being annoying, sorry
Signed-off-by: Eduardo Rodrigues <[email protected]>
…r/argo-workflows into fix-prometheus-metrics
Joibel
approved these changes
Oct 24, 2025
argo-cd-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Eduardo Rodrigues <[email protected]> Co-authored-by: Alan Clucas <[email protected]>
|
🍒 Cherry-pick PR created for 3.7: #14987 |
ItielOlenick
pushed a commit
to ItielOlenick/argo-workflows
that referenced
this pull request
Oct 26, 2025
…proj#14879) Signed-off-by: Eduardo Rodrigues <[email protected]> Co-authored-by: Alan Clucas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14755
Motivation
Modifications
By default, prometheus has NameValidationScheme set to UTF8Validation which allows metrics names to keep original delimiters (e.g. .), rather than replacing with underscores. This PR adds a new env var
PROMETHEUS_LEGACY_NAME_VALIDATION_SCHEMEto allow users to revert to the legacy behavior.Verification
Deployed controller with prometheus scraping. I used prometheus operator.
Documentation