fix: process aggregate outputs for steps node with retries. Fixes #14647 #14651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/retest |
isubasinghe
reviewed
Jul 14, 2025
…oproj#14647 Signed-off-by: oninowang <[email protected]>
Member
Author
|
/retest |
Member
|
Okay I think lets do a proper non-parsing based fix later. I am just going to accept this for now. |
isubasinghe
approved these changes
Jul 15, 2025
Member
isubasinghe
left a comment
isubasinghe
left a comment
There was a problem hiding this comment.
Lets fix this properly in 3.8
isubasinghe
pushed a commit
that referenced
this pull request
Jul 15, 2025
(#14651) Signed-off-by: oninowang <[email protected]>
Member
|
/cherry-pick release-3.6 |
Member
|
/cherry-pick release-3.7 |
This was referenced Aug 6, 2025
Joibel
pushed a commit
that referenced
this pull request
Aug 6, 2025
(#14651) Signed-off-by: oninowang <[email protected]> (cherry picked from commit 85b4c64)
Joibel
added a commit
that referenced
this pull request
Aug 8, 2025
(#14651) (release-3.6) (#14746) Signed-off-by: oninowang <[email protected]> Co-authored-by: jswxstw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14647
Motivation
Modifications
Filter retried nodes and only aggregate outputs of their parent nodes.
Verification
E2E test and local test
Documentation