Skip to content

feat(metricprovider): credentials to download plugin#3905

Merged
zachaller merged 6 commits intoargoproj:masterfrom
adevinta:plugin
Dec 4, 2024
Merged

feat(metricprovider): credentials to download plugin#3905
zachaller merged 6 commits intoargoproj:masterfrom
adevinta:plugin

Conversation

@ariadnarouco
Copy link
Contributor

@ariadnarouco ariadnarouco commented Oct 18, 2024

In our company, we have a use case where we need to create a new plugin as a metric provider. For security reasons the plugin needs to be private and cannot be uploaded to a public storage.
Therefore, we have the need to use credentials for downloading the plugin securely.

We have followed k8s secretRef pattern to specify how the credentials are passed.

Additionally, we had an issue with 404 status code. The downloader says that the plugin is downloaded correctly but it’s not true.

Fixes: #3708

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024

Published E2E Test Results

  4 files    4 suites   3h 14m 38s ⏱️
113 tests 104 ✅  7 💤 2 ❌
454 runs  424 ✅ 28 💤 2 ❌

For more details on these failures, see this check.

Results for commit 2b091a2.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024

Published Unit Test Results

2 285 tests   2 285 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit 2b091a2.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.97%. Comparing base (5f59344) to head (2b091a2).
Report is 110 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3905      +/-   ##
==========================================
+ Coverage   82.69%   82.97%   +0.28%     
==========================================
  Files         163      163              
  Lines       22895    22914      +19     
==========================================
+ Hits        18934    19014      +80     
+ Misses       3087     3027      -60     
+ Partials      874      873       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ariadnarouco ariadnarouco changed the title feat(plugin): credentials to download plugin feat(metricprovider): credentials to download plugin Oct 18, 2024
@ariadnarouco ariadnarouco force-pushed the plugin branch 3 times, most recently from 955ac0a to cfa0cf8 Compare October 23, 2024 14:10
@ariadnarouco ariadnarouco reopened this Nov 4, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@zachaller zachaller added this to the v1.8 milestone Nov 4, 2024
Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>
Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>
Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>
Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>
Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>
Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>
@sonarqubecloud
Copy link

@zachaller zachaller merged commit 7c06316 into argoproj:master Dec 4, 2024
@cmalladi7
Copy link

Can we create a release with this change in please? This is useful for us to make our plugin private as well. Would also love to have a release made in the argo-helm project for the new version.

Thank you!

Rizwana777 pushed a commit to Rizwana777/argo-rollouts that referenced this pull request Dec 12, 2024
* adding logic to defined headers to download plugins from secure sources.

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>

* adding documentation for plugin download headers

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>

* removing insignificant line.

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>

* increasing coverage

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>

* adding coverage.

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>

* malformed url case coverage.

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>

---------

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>
meeech pushed a commit to CircleCI-Public/argo-rollouts that referenced this pull request Feb 10, 2025
* adding logic to defined headers to download plugins from secure sources.

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>

* adding documentation for plugin download headers

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>

* removing insignificant line.

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>

* increasing coverage

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>

* adding coverage.

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>

* malformed url case coverage.

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>

---------

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>
tperdue321 pushed a commit to tperdue321/argo-rollouts that referenced this pull request Mar 28, 2025
* adding logic to defined headers to download plugins from secure sources.

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>

* adding documentation for plugin download headers

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>

* removing insignificant line.

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>

* increasing coverage

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>

* adding coverage.

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>

* malformed url case coverage.

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>

---------

Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There should be an error message when URL is invalid and the plugin isn't downloaded

3 participants

Comments