Skip to content

docs(argo-cd): Correct Changelog in README for v9.0.0 #3546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tico24 merged 1 commit into from
Oct 20, 2025
+9 −11
Merged

docs(argo-cd): Correct Changelog in README for v9.0.0 #3546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/argo-cd/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: v3.1.9
kubeVersion: ">=1.25.0-0"
description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes.
name: argo-cd
version: 9.0.1
version: 9.0.2
home: https://github.com/argoproj/argo-helm
icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
sources:
Expand All @@ -26,5 +26,5 @@ annotations:
fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: changed
description: Bump argo-cd to v3.1.9
- kind: fixed
description: Correct Changelog in README for v9.0.0
7 changes: 3 additions & 4 deletions charts/argo-cd/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ For full list of changes please check ArtifactHub [changelog].
Highlighted versions provide information about additional steps that should be performed by user when upgrading to newer version.

### 9.0.0
We have removed all parameters under `.Values.configs.cm.params` in this release, with the exception of `create` and `annotations`.
We have removed all parameters under `.Values.configs.params` in this release, with the exception of `create` and `annotations`.
This is to ensure better alignment with the upstream project, as tracking changes to their default values within the Helm chart has become challenging.

**Breaking change**
Expand All @@ -409,9 +409,8 @@ To restore the previous setting, you can override the argocd-cmd-params-cm Confi

```yaml
configs:
cm:
params:
applicationsetcontroller.policy: 'sync'
params:
applicationsetcontroller.policy: 'sync'
```

### 8.0.0
Expand Down
7 changes: 3 additions & 4 deletions charts/argo-cd/README.md.gotmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ For full list of changes please check ArtifactHub [changelog].
Highlighted versions provide information about additional steps that should be performed by user when upgrading to newer version.

### 9.0.0
We have removed all parameters under `.Values.configs.cm.params` in this release, with the exception of `create` and `annotations`.
We have removed all parameters under `.Values.configs.params` in this release, with the exception of `create` and `annotations`.
This is to ensure better alignment with the upstream project, as tracking changes to their default values within the Helm chart has become challenging.

**Breaking change**
Expand All @@ -409,9 +409,8 @@ To restore the previous setting, you can override the argocd-cmd-params-cm Confi

```yaml
configs:
cm:
params:
applicationsetcontroller.policy: 'sync'
params:
Copy link

@tgdfool2 tgdfool2 Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is really correct?

We have removed all parameters under .Values.configs.params

So why changing it to configs.params here?

Copy link
Collaborator Author

@yu-croco yu-croco Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tgdfool2
We removed it because upstream has default value and they sometimes change the default value. We cannot catch up all the changes, especially this is out of k8s manifest. But we keep providing the interface to override them, so users can use the parameters like older version.

Ref:

Copy link

@tgdfool2 tgdfool2 Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I see, thanks for clarifying

Copy link
Collaborator Author

@yu-croco yu-croco Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it was better to add context like below? 🤔

We have removed all parameters under `.Values.configs.params` in this release, with the exception of `create` and `annotations`.
This is to ensure better alignment with the upstream project, as tracking changes to their default values within the Helm chart has become challenging.

+ **Though we removed the parameters from values.yaml in argo-helm, we keep providing the interface to override `.Values.configs.params`. **

applicationsetcontroller.policy: 'sync'
```

### 8.0.0
Expand Down