Skip to content

Conversation

@alexmt
Copy link
Collaborator

@alexmt alexmt commented Jan 28, 2022

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #8311 (2d43e0d) into master (4aa614d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8311   +/-   ##
=======================================
  Coverage   41.91%   41.91%           
=======================================
  Files         176      176           
  Lines       22992    22992           
=======================================
  Hits         9637     9637           
  Misses      11972    11972           
  Partials     1383     1383           
Impacted Files Coverage Δ
util/settings/settings.go 47.08% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa614d...2d43e0d. Read the comment docs.

@alexmt alexmt merged commit d2a3a4d into argoproj:master Jan 28, 2022
@alexmt alexmt deleted the fix-release-workflow branch January 28, 2022 20:04
alexmt pushed a commit that referenced this pull request Jan 28, 2022
)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
pasha-codefresh pushed a commit to pasha-codefresh/argo-cd that referenced this pull request Feb 2, 2022
…goproj#8311)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants