feat: Zoom in and out on resource view (#7183) #8290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Zoom out 40%: Zoom in 150%: Group nodes enabled: |
keithchong
force-pushed
the
7183-ZoomSupport
branch
from
06dfdb6 to
1e37969
Compare
Codecov Report
@@ Coverage Diff @@
## master #8290 +/- ##
==========================================
+ Coverage 41.63% 41.93% +0.29%
==========================================
Files 174 176 +2
Lines 22881 22992 +111
==========================================
+ Hits 9527 9641 +114
+ Misses 11990 11966 -24
- Partials 1364 1385 +21
Continue to review full report at Codecov.
|
Contributor
Author
keithchong
force-pushed
the
7183-ZoomSupport
branch
from
1e37969 to
ddac8f4
Compare
Signed-off-by: Keith Chong <[email protected]>
keithchong
force-pushed
the
7183-ZoomSupport
branch
from
ddac8f4 to
e35bfdf
Compare
alexmt
approved these changes
Jan 27, 2022
Collaborator
alexmt
left a comment
alexmt
left a comment
There was a problem hiding this comment.
That is just awesome!
Can we persist zoom settings in user preferences for consistency? This definitely can be done later.
LGTM
Contributor
|
This is such a cool feature! |
pasha-codefresh
pushed a commit
to pasha-codefresh/argo-cd
that referenced
this pull request
Feb 2, 2022
Signed-off-by: Keith Chong <[email protected]> Signed-off-by: pashavictorovich <[email protected]>
9 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Keith Chong [email protected]
About this PR:
Addresses #7183
This zoom implementation is strictly transformation, which is option/solution A. Panning is limited to scrolling of the enlarged rectangular area, and isn't truly panning of a view-box typical of SVG graphics. For option B, we could convert to all SVG but its performance degrades for many rendered objects. I've investigated this more and there is a bit of work involved.
Zoom level is not made a view preference on the details page so that the UI in multiple browser tabs can have different zoom values. Drawback is that the zoom level will reset each time you exit and enter the details page, and it's different behavior than the grouped-node button. However, zoom level is maintained when switching from tree view to network view and vice versa.
Grouped-node button moved to floating graph toolbar. Zoom buttons similar to the ones seen in the Argo Workflows UI.
CSS and tool bar can be moved to argo-ui, but is not part of this PR
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: