Skip to content

feat(cli): allow app diff to compare manifest with desired state (#21059)#27469

Open
agaudreault wants to merge 46 commits into
argoproj:masterfrom
agaudreault:diff-desired-state
Open

feat(cli): allow app diff to compare manifest with desired state (#21059)#27469
agaudreault wants to merge 46 commits into
argoproj:masterfrom
agaudreault:diff-desired-state

Conversation

@agaudreault
Copy link
Copy Markdown
Member

@agaudreault agaudreault commented Apr 20, 2026

Requires #27703

Fixes #21059

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
…taate without live diffs

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
…mand

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault requested a review from a team as a code owner April 20, 2026 21:40
@bunnyshell
Copy link
Copy Markdown

bunnyshell Bot commented Apr 20, 2026

❌ Preview Environment undeployed from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@agaudreault agaudreault marked this pull request as draft April 20, 2026 21:42
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

❌ Patch coverage is 44.11765% with 19 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@a5012a0). Learn more about missing BASE report.
⚠️ Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/app_diff.go 45.45% 18 Missing ⚠️
cmd/argocd/commands/app.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #27469   +/-   ##
=========================================
  Coverage          ?   64.23%           
=========================================
  Files             ?      422           
  Lines             ?    57858           
  Branches          ?        0           
=========================================
  Hits              ?    37165           
  Misses            ?    17188           
  Partials          ?     3505           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault marked this pull request as ready for review May 12, 2026 20:58
@agaudreault agaudreault requested a review from a team as a code owner May 12, 2026 20:58
Comment thread docs/user-guide/commands/argocd_app_diff.md Outdated
Comment thread test/e2e/diff_test.go Outdated
Comment thread cmd/argocd/commands/app_diff.go
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
…ion attack

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault enabled auto-merge (squash) May 14, 2026 21:57
@agaudreault agaudreault requested a review from pjiang-dev May 15, 2026 15:43
Copy link
Copy Markdown
Contributor

@pjiang-dev pjiang-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agaudreault agaudreault added the ready-for-review An approver should give a final review and merge the PR label May 19, 2026
@github-project-automation github-project-automation Bot moved this to Ready for final review in Argo CD Review May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review An approver should give a final review and merge the PR

Projects

Status: Ready for final review

Development

Successfully merging this pull request may close these issues.

CLI: add possibility to diff the desired state instead of the live state

3 participants