fix: capture stderr in executil RunWithExecRunOpts #25139
Merged
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eugene Doudine <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
reggie-k
approved these changes
Nov 2, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25139 +/- ##
==========================================
+ Coverage 62.24% 62.25% +0.01%
==========================================
Files 351 351
Lines 49213 49213
==========================================
+ Hits 30631 30639 +8
+ Misses 15655 15644 -11
- Partials 2927 2930 +3 ☔ View full report in Codecov by Sentry. |
reggie-k
added
the
cherry-pick/3.2
argo-cd-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Nov 2, 2025
Signed-off-by: Eugene Doudine <[email protected]>
|
🍒 Cherry-pick PR created for 3.2: #25140 |
blakepettersson
pushed a commit
that referenced
this pull request
Nov 2, 2025
…for 3.2) (#25140) Signed-off-by: Eugene Doudine <[email protected]> Co-authored-by: dudinea <[email protected]>
reggie-k
added
cherry-pick/3.1
argo-cd-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Nov 2, 2025
Signed-off-by: Eugene Doudine <[email protected]>
|
🍒 Cherry-pick PR created for 3.1: #25141 |
|
❌ Cherry-pick failed for 3.0. Please check the workflow logs for details. |
blakepettersson
pushed a commit
that referenced
this pull request
Nov 3, 2025
…for 3.1) (#25141) Signed-off-by: Eugene Doudine <[email protected]> Co-authored-by: dudinea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in RunWithExecRunOpts that did not pass the CaptureStderr option
down to the RunCommandExt, resulting in stderr not being captured when requested.
The option currently is not set in any code, so this bug/patch does not
affect any functionality. This patch is required for implementing a test
in another PR (25127) i'm working on.
I'm not sure if I need to open a new Issue just for this
Checklist: