Skip to content

Conversation

@dhruvang1
Copy link
Contributor

@dhruvang1 dhruvang1 commented Oct 28, 2025

Implement the server side pagination and update UI to use it. The CLI is updated to just add support for limit and offset. Few quirks with this implementation:

  • Search autocomplete does not show all apps. Perhaps an additional call to list API can be made to fetch all app names, but list will be slow on large instance.
  • Summary view of apps shows wonky numbers when a filter (health / sync) is selected (eg. total: 2, synced: 2000). This is because of how the numbers are calculated on server side vs client side.
  • Summary view does not show accurate numbers for hydrator. Perhaps that should be fetched from server as well.
  • When a filter (eg Out of sync) is selected, the server will actually filter out the watch update which makes it healthy, so the UI will see the app as Out of sync, till another list request is made. Not sure whats the best way to handle this.
  • In a rapidly changing cluster, its notable that stats are outdated. A periodic restart of list + watch on UI seems like a reasonable idea, but list API can take a while to respond because of slow RBAC evaluation.
  • All apps marked as favorites are sent as explicit list. This may run into GET url length limitation of 2000 characters. Couldn't think of any other reasonable alternatives.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Fixes #14947

@dhruvang1 dhruvang1 requested review from a team as code owners October 28, 2025 01:52
@bunnyshell
Copy link

bunnyshell bot commented Oct 28, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Signed-off-by: Dhruvang Makadia <[email protected]>
@dhruvang1 dhruvang1 force-pushed the server-side-pagination branch from 5408d8f to 3de8730 Compare October 28, 2025 05:56
@dhruvang1 dhruvang1 requested a review from a team as a code owner October 28, 2025 05:56
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I'll bring it up in contrib meeting today. I suspect that some of the quirks will make it so we can't merge it yet but we also don't want to have a giant PR to merge later when these issues are worked out. We basically need to move all these things to be server side requests to prevent those issues. I'll share the feedback from today's discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server-side pagination to make ArgoCD UI a rocket

2 participants