fix(health): use promotion resource Ready condition regardless of reason #24971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Michael Crenshaw <[email protected]>
crenshaw-dev
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24971 +/- ##
=========================================
Coverage ? 60.84%
=========================================
Files ? 351
Lines ? 60489
Branches ? 0
=========================================
Hits ? 36807
Misses ? 20753
Partials ? 2929 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
added
component:cache
argo-cd-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
…son (#24971) Signed-off-by: Michael Crenshaw <[email protected]>
|
❌ Cherry-pick failed for 3.0. Please check the workflow logs for details. |
|
❌ Cherry-pick failed for 3.1. Please check the workflow logs for details. |
|
🍒 Cherry-pick PR created for 3.2: #24973 |
crenshaw-dev
added a commit
that referenced
this pull request
Oct 16, 2025
…son (cherry-pick #24971 for 3.2) (#24973) Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
dzahariev
pushed a commit
to dzahariev/argo-cd
that referenced
this pull request
Oct 20, 2025
…son (argoproj#24971) Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Dobromir Zahariev <[email protected]>
devopsjedi
pushed a commit
to devopsjedi/argo-cd
that referenced
this pull request
Oct 21, 2025
…son (argoproj#24971) Signed-off-by: Michael Crenshaw <[email protected]>
AvhiMaz
pushed a commit
to AvhiMaz/argo-cd
that referenced
this pull request
Nov 3, 2025
…son (argoproj#24971) Signed-off-by: Michael Crenshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we only catch Ready=False if the reason is ReconciliationError. But GitOps Promoter now produces other reasons. So right now we miss the failure condition and instead fall into logic about missing data in the
status.environmentsblock.The change handles Ready=False regardless of reason. It injects the reason name in the message if it's not just ReconciliationError.