fix: allow for backwards compatibility of durations defined in days #24769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
lplazas
force-pushed
the
fix/time-duration-parsing-v2-14
branch
from
a1c1432 to
51c5cfa
Compare
lplazas
changed the title
lplazas
force-pushed
the
fix/time-duration-parsing-v2-14
branch
from
51c5cfa to
bd2d697
Compare
Contributor
Author
|
@crenshaw-dev for visibility |
Signed-off-by: lplazas <[email protected]>
lplazas
force-pushed
the
fix/time-duration-parsing-v2-14
branch
from
bd2d697 to
319363f
Compare
blakepettersson
changed the title
blakepettersson
added
cherry-pick/3.0
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24769 +/- ##
=======================================
Coverage 60.70% 60.70%
=======================================
Files 404 404
Lines 66092 66096 +4
=======================================
+ Hits 40121 40125 +4
- Misses 22722 22723 +1
+ Partials 3249 3248 -1 ☔ View full report in Codecov by Sentry. |
argo-cd-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Sep 28, 2025
…24769) Signed-off-by: lplazas <[email protected]>
argo-cd-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Sep 28, 2025
…24769) Signed-off-by: lplazas <[email protected]>
argo-cd-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Sep 28, 2025
…24769) Signed-off-by: lplazas <[email protected]>
|
🍒 Cherry-pick PR created for 3.0: #24770 |
|
🍒 Cherry-pick PR created for 3.1: #24771 |
This was referenced Sep 28, 2025
|
🍒 Cherry-pick PR created for 2.14: #24772 |
nitishfy
pushed a commit
that referenced
this pull request
Sep 29, 2025
…cherry-pick #24769 for 3.1) (#24771) Signed-off-by: lplazas <[email protected]> Co-authored-by: lplazas <[email protected]>
nitishfy
pushed a commit
that referenced
this pull request
Sep 29, 2025
…cherry-pick #24769 for 3.0) (#24770) Signed-off-by: lplazas <[email protected]> Co-authored-by: lplazas <[email protected]>
crenshaw-dev
pushed a commit
that referenced
this pull request
Sep 29, 2025
…cherry-pick #24769 for 2.14) (#24772) Signed-off-by: lplazas <[email protected]> Co-authored-by: lplazas <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #24740
This bug was introduced in v2.14.0 and has been in every v2.14 and v3 release ever since.
To note
All the test cases pass with the pre-v2.14 version with one notable exception: https://github.com/argoproj/argo-cd/pull/24769/files#diff-f4cf5d4ad87bc07ff0573f18f4b68af0adf34871c09b32eae1554b3334e5a93cR183
time.ParseDuration allows for decimal durations (1.5h, 5.5m, etc), while the old function didn't.
Checklist: