Skip to content

fix: update ExternalSecret discovery.lua to also include the refreshPolicy #24707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2025
Merged

fix: update ExternalSecret discovery.lua to also include the refreshPolicy #24707

merged 2 commits into from
Sep 23, 2025

Conversation

@KyriosGN0
Copy link
Contributor

@KyriosGN0 KyriosGN0 commented Sep 23, 2025 •
edited
Loading

Signed-off-by: AvivGuiser [email protected]

Closes #24554

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@KyriosGN0 KyriosGN0 requested a review from a team as a code owner September 23, 2025 09:28
@bunnyshell
Copy link

bunnyshell bot commented Sep 23, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov
Copy link

codecov bot commented Sep 23, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.46%. Comparing base (452f6c6) to head (d46f556).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #24707      +/-   ##
==========================================
- Coverage   60.51%   60.46%   -0.05%     
==========================================
  Files         350      350              
  Lines       60196    60196              
==========================================
- Hits        36430    36400      -30     
- Misses      20832    20856      +24     
- Partials     2934     2940       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KyriosGN0
Copy link
Contributor Author

i think that the test failure are unrelated to my changes

@crenshaw-dev crenshaw-dev added cherry-pick/3.1 Candidate for cherry picking into the 3.1 release branch cherry-pick/3.2 Candidate for cherry picking into the 3.2 release branch labels Sep 23, 2025
crenshaw-dev
crenshaw-dev approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) September 23, 2025 16:39
@crenshaw-dev crenshaw-dev merged commit c3079fc into argoproj:master Sep 23, 2025
53 of 56 checks passed
argo-cd-cherry-pick-bot bot pushed a commit that referenced this pull request Sep 23, 2025
@KyriosGN0 @github-actions
fix: update ExternalSecret discovery.lua to also include the refreshP…
d355c8f 
…olicy (#24707)

Signed-off-by: AvivGuiser <[email protected]>
argo-cd-cherry-pick-bot bot pushed a commit that referenced this pull request Sep 23, 2025
@KyriosGN0 @github-actions
fix: update ExternalSecret discovery.lua to also include the refreshP…
77dbf50 
…olicy (#24707)

Signed-off-by: AvivGuiser <[email protected]>
@argo-cd-cherry-pick-bot
Copy link

🍒 Cherry-pick PR created for 3.1: #24712

This was referenced Sep 23, 2025
Merged
Merged
@argo-cd-cherry-pick-bot
Copy link

🍒 Cherry-pick PR created for 3.2: #24713

crenshaw-dev pushed a commit that referenced this pull request Sep 23, 2025
@argo-cd-cherry-pick-bot @KyriosGN0
fix: update ExternalSecret discovery.lua to also include the refreshP…
087378c 
…olicy (cherry-pick #24707 for 3.2) (#24713)

Signed-off-by: AvivGuiser <[email protected]>
Co-authored-by: AvivGuiser <[email protected]>
crenshaw-dev pushed a commit that referenced this pull request Sep 23, 2025
@argo-cd-cherry-pick-bot @KyriosGN0
fix: update ExternalSecret discovery.lua to also include the refreshP…
54bab39 
…olicy (cherry-pick #24707 for 3.1) (#24712)

Signed-off-by: AvivGuiser <[email protected]>
Co-authored-by: AvivGuiser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees

No one assigned

Labels

cherry-pick/3.1 Candidate for cherry picking into the 3.1 release branch cherry-pick/3.2 Candidate for cherry picking into the 3.2 release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow to Refresh an ExternalSecret if its RefreshPolicy is OnChange

2 participants

@KyriosGN0 @crenshaw-dev