fix(oci): loosen up layer restrictions #24640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes argoproj#24564. We only allow for a single OCI _content_ layer (or rather a single layer containing manifests), but there are images that contain multiple layers, notably anything that uses attestation/provenance. For example Helm has a application/vnd.cncf.helm.chart.provenance.v1.prov layer if a chart has been signed. Pending a better story where we would verify these images natively, for now let's skip those layers and only take actual content layers into account. Signed-off-by: Blake Pettersson <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
blakepettersson
added
cherry-pick/3.1
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24640 +/- ##
==========================================
- Coverage 60.46% 60.46% -0.01%
==========================================
Files 350 350
Lines 60105 60187 +82
==========================================
+ Hits 36345 36391 +46
- Misses 20828 20848 +20
- Partials 2932 2948 +16 ☔ View full report in Codecov by Sentry. |
gdsoumya
approved these changes
Sep 18, 2025
argo-cd-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Sep 18, 2025
Signed-off-by: Blake Pettersson <[email protected]>
|
🍒 Cherry-pick PR created for 3.2: #24648 |
argo-cd-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Sep 18, 2025
Signed-off-by: Blake Pettersson <[email protected]>
This was referenced Sep 18, 2025
|
🍒 Cherry-pick PR created for 3.1: #24649 |
blakepettersson
added a commit
that referenced
this pull request
Sep 18, 2025
…24649) Signed-off-by: Blake Pettersson <[email protected]> Co-authored-by: Blake Pettersson <[email protected]>
blakepettersson
added a commit
that referenced
this pull request
Sep 18, 2025
…24648) Signed-off-by: Blake Pettersson <[email protected]> Co-authored-by: Blake Pettersson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24564. We only allow for a single OCI content layer (or rather a single layer containing manifests), but there are images that contain multiple layers, notably anything that uses attestation/provenance. For example Helm has an
application/vnd.cncf.helm.chart.provenance.v1.provlayer if a chart has been signed.Pending a better story where we would verify these images natively, for now let's skip those layers and only take actual content layers into account.
Checklist: