-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore: bumps redis version to 8.2.1 #24523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bumps redis version to 8.2.1 #24523
Conversation
Signed-off-by: Patroklos Papapetrou <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24523 +/- ##
==========================================
- Coverage 60.45% 60.43% -0.02%
==========================================
Files 350 350
Lines 60141 60141
==========================================
- Hits 36357 36347 -10
- Misses 20847 20856 +9
- Partials 2937 2938 +1 ☔ View full report in Codecov by Sentry. |
|
didn't we plan to replace redis with valkey? |
I'm not aware of this and if even if we do plan to replace it, this doesn't change the. need to use a newer and free of security issues redis version. |
Signed-off-by: Patroklos Papapetrou <[email protected]>
Signed-off-by: Patroklos Papapetrou <[email protected]>
Signed-off-by: Patroklos Papapetrou <[email protected]>
I think a separate effort can be made to provide a Valkey config in argo-cd, like another Kustomize layer for the manifests and an additional values.yaml for Valkey file in argo-helm and Valkey chart dependency that will depend on whether Valkey or Redis are enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Will wait for more feedback from other maintainers before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Let's go ahead and get this into 3.2. |
Signed-off-by: Patroklos Papapetrou <[email protected]>
|
🍒 Cherry-pick PR created for 3.2: #24582 |
|
😍 the cherry-pick bot |
) Signed-off-by: Patroklos Papapetrou <[email protected]> Co-authored-by: Papapetrou Patroklos <[email protected]>
Bumps redis version to 8.2.1.
The current version is full of vulnerabilities
Checklist:
Closes #24521