Skip to content

Conversation

@ppapapetrou76
Copy link
Contributor

@ppapapetrou76 ppapapetrou76 commented Sep 11, 2025

Bumps redis version to 8.2.1.
The current version is full of vulnerabilities

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Closes #24521

Signed-off-by: Patroklos Papapetrou <[email protected]>
@ppapapetrou76 ppapapetrou76 requested review from a team as code owners September 11, 2025 12:42
@bunnyshell
Copy link

bunnyshell bot commented Sep 11, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.43%. Comparing base (2bba563) to head (83c5eac).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #24523      +/-   ##
==========================================
- Coverage   60.45%   60.43%   -0.02%     
==========================================
  Files         350      350              
  Lines       60141    60141              
==========================================
- Hits        36357    36347      -10     
- Misses      20847    20856       +9     
- Partials     2937     2938       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nitishfy
Copy link
Member

didn't we plan to replace redis with valkey?

@ppapapetrou76
Copy link
Contributor Author

didn't we plan to replace redis with valkey?

I'm not aware of this and if even if we do plan to replace it, this doesn't change the. need to use a newer and free of security issues redis version.

@reggie-k
Copy link
Member

reggie-k commented Sep 16, 2025

didn't we plan to replace redis with valkey?

I think a separate effort can be made to provide a Valkey config in argo-cd, like another Kustomize layer for the manifests and an additional values.yaml for Valkey file in argo-helm and Valkey chart dependency that will depend on whether Valkey or Redis are enabled.

Copy link
Member

@reggie-k reggie-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will wait for more feedback from other maintainers before merging.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@crenshaw-dev crenshaw-dev merged commit 1d13ebc into argoproj:master Sep 16, 2025
28 checks passed
@crenshaw-dev
Copy link
Member

Let's go ahead and get this into 3.2.

@crenshaw-dev crenshaw-dev added the cherry-pick/3.2 Candidate for cherry picking into the 3.2 release branch label Sep 16, 2025
argo-cd-cherry-pick-bot bot pushed a commit that referenced this pull request Sep 16, 2025
@argo-cd-cherry-pick-bot
Copy link

🍒 Cherry-pick PR created for 3.2: #24582

@blakepettersson
Copy link
Member

😍 the cherry-pick bot

crenshaw-dev pushed a commit that referenced this pull request Sep 16, 2025
)

Signed-off-by: Patroklos Papapetrou <[email protected]>
Co-authored-by: Papapetrou Patroklos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick/3.2 Candidate for cherry picking into the 3.2 release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade redis to 8.x

5 participants