chore(refactor): use contexts in hydration operations #24431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Michael Crenshaw <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24431 +/- ##
=========================================
Coverage ? 60.27%
=========================================
Files ? 350
Lines ? 59980
Branches ? 0
=========================================
Hits ? 36154
Misses ? 20924
Partials ? 2902 ☔ View full report in Codecov by Sentry. |
Mangaal
pushed a commit
to Mangaal/argo-cd
that referenced
this pull request
Sep 10, 2025
Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Mangaal <[email protected]>
LogicalShark
pushed a commit
to LogicalShark/argo-cd
that referenced
this pull request
Sep 10, 2025
Signed-off-by: Michael Crenshaw <[email protected]>
Hapshanko
pushed a commit
to Hapshanko/argo-cd
that referenced
this pull request
Sep 12, 2025
Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Hapshanko <[email protected]>
downfa11
pushed a commit
to downfa11/argo-cd
that referenced
this pull request
Sep 12, 2025
Signed-off-by: Michael Crenshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetRepoObjsis the controller's way of calling repo-server to get manifests.Getting manifests is a long-ish-running operation. We should really be using contexts through all this code so that timeouts can be easily implemented.
This PR is purely a refactor to centralize the
context.Background()in a few key places so that we can introduce timeouts and short-circuiting later.My immediate motivation is using an errgroup context to short-circuit parallel calls to repo-server in Source Hydrator when one of those calls fails. No need to wait for all the other calls to finish when one has already failed. I'll open a follow-up PR to introduce that parallelization.