fix: Progress Sync Unknown in UI #24202

aali309 · 2025-08-19T21:23:54Z

Closes: #24190
Closes: #24296

Checklist:

bunnyshell · 2025-08-19T21:24:00Z

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

🚀 /bns:deploy to deploy the environment

aali309 · 2025-08-20T01:25:11Z

@reggie-k, can you please review this for me! Thnx

nitishfy

Thank you for raising the PR. Can you please attach a demonstration video if possible?

aali309 · 2025-08-20T12:59:32Z

updatedFix.mov

dag-andersen · 2025-08-21T10:45:46Z

ui/src/app/applications/components/application-status-panel/application-status-panel.tsx

 const hasRollingSyncEnabled = (application: models.Application): boolean => {
+    // Only show Progressive Sync for applications that have an ApplicationSet owner reference
+    // The actual strategy validation is done in the ProgressiveSyncStatus component
    return application.metadata.ownerReferences?.some(ref => ref.kind === 'ApplicationSet') || false;
 };


Hi @aali309

It’s me from the reported issue: #24190 (comment) :)

Maybe I’m missing something, but wouldn’t it be more fitting to rename this function to hasApplicationSetParent or isPartOfApplicationSet or something similar?

The function only checks if there’s an owner reference pointing to an ApplicationSet, and does not check if rolling sync has been enabled. I understand that the sync-strategy is checked later in the code, but I would argue that the current function name is a bit misleading considering what it actually does.

nitishfy · 2025-08-21T11:52:58Z

updatedFix.mov

We are currently hiding that icon. What about the case when it has been enabled and shouldn't be unknown?

aali309 · 2025-08-21T13:05:51Z

updatedFix.mov

We are currently hiding that icon. What about the case when it has been enabled and shouldn't be unknown?

current logic, I believe it's working correctly:
When rolling sync is enabled and status is available: Shows the actual progressive sync status
When rolling sync is enabled but status not yet populated: Shows "Waiting" status (not "Unknown")
When ApplicationSet doesn't use RollingSync strategy: Hides the section entirely (return null)

aali309 · 2025-08-21T18:12:15Z

updatedFix.mov

We are currently hiding that icon. What about the case when it has been enabled and shouldn't be unknown?

current logic, I believe it's working correctly: When rolling sync is enabled and status is available: Shows the actual progressive sync status When rolling sync is enabled but status not yet populated: Shows "Waiting" status (not "Unknown") When ApplicationSet doesn't use RollingSync strategy: Hides the section entirely (return null)

This is when its enabled

reggie-k · 2025-08-24T06:50:46Z

@aali309 Could you attach a screenshot of how it looks like when the App is part of a progressive sync but the user has no permissions on the AppSet? I'm asking myself for this case, should we even display the progressive sync status for the App?

aali309 · 2025-08-27T12:30:08Z

@aali309 Could you attach a screenshot of how it looks like when the App is part of a progressive sync but the user has no permissions on the AppSet? I'm asking myself for this case, should we even display the progressive sync status for the App?

I think its better to create a follow up PR to close this access denied issue #24225

I was also thinking to have something like this

For user awareness, it informs users that there is progressive sync information available, but they don't have access to it. WDYT?

reggie-k · 2025-08-28T06:58:16Z

I like this approach, but not sure, from security point if view, that we are not disclosing info that isn't supposed to be disclosed. Would love to hear @crenshaw-dev or @agaudreault 's take on this. I'm adding it to today's contributor agenda meeting for discussion.

aali309 · 2025-08-28T16:03:12Z

I like this approach, but not sure, from security point if view, that we are not disclosing info that isn't supposed to be disclosed. Would love to hear @crenshaw-dev or @agaudreault 's take on this. I'm adding it to today's contributor agenda meeting for discussion.

Thank you @reggie-k , so I guess we are disabling it

reggie-k · 2025-08-28T16:10:22Z

@aali309 Please see the summary from today's contributor meeting (the RBAC + docs stuff can go into another PR)
#24190 (comment)

reggie-k · 2025-08-28T16:20:40Z

I believe we would need the following scenarios tested:

Application page for an app that is part of an AppSet WITH progressive sync and user WITH permissions on the AppSet (either an admin or has explicit permissions) - the panel should be shown
Application page for an app that is part of an AppSet WITH progressive sync and user WITHOUT permissions on the AppSet - the panel should be hidden
Application page for an app that is part of an AppSet WITHOUT progressive sync and user WITH permissions on the AppSet (either an admin or has explicit permissions)- the panel should be hidden
Application page for an app that is part of an AppSet WITHOUT progressive sync and user WITHOUT permissions for the AppSet - the panel should be hidden
Application page for an app that is NOT part of an AppSet - the panel should be hidden

aali309 · 2025-09-04T18:06:51Z

I believe we would need the following scenarios tested:

Application page for an app that is part of an AppSet WITH progressive sync and user WITH permissions on the AppSet (either an admin or has explicit permissions) - the panel should be shown

Application page for an app that is part of an AppSet WITH progressive sync and user WITHOUT permissions on the AppSet - the panel should be hidden

Application page for an app that is part of an AppSet WITHOUT progressive sync and user WITH permissions on the AppSet (either an admin or has explicit permissions)- the panel should be hidden

Application page for an app that is part of an AppSet WITHOUT progressive sync and user WITHOUT permissions for the AppSet - the panel should be hidden

Application page for an app that is NOT part of an AppSet - the panel should be hidden

Tested all these 5 scenarios @reggie-k @agaudreault PTAL.

ranakan19 · 2025-09-05T02:19:37Z

ui/src/app/applications/components/application-status-panel/application-status-panel.tsx

-    const appSetRef = application.metadata.ownerReferences.find(ref => ref.kind === 'ApplicationSet');
+const isPermissionError = (error: any): boolean => {
+    const errorText = extractErrorText(error);
+    return errorText.includes('Failed to load data');


Relying on error text is fragile, could you look into the error object when permissionError occurs to see if something like errorCode or statusCode(403) or error type exists and use that instead?

This is what I thought initially but here's what I found:

The DataLoader component wraps HTTP errors in React elements, so we can't directly access HTTP status codes like error.status or error.statusText.
Therefore:
error.status → undefined (not accessible)
error.statusText → undefined (not accessible)
error.response → undefined (not accessible)
error.code → undefined (not accessible)

It will be better to check for permissions explicitly using can-i, like here:

argo-cd/ui/src/app/applications/components/resource-details/resource-details.tsx

Line 284 in 993344e

const logsAllowed = await services.accounts.canI('logs', 'get', application.spec.project + '/' + application.metadata.name);

Showing / hiding logs of pods in the App is done with a similar logic - shown if the user has permissions, hidden otherwise.

ui/src/app/applications/components/application-status-panel/application-status-panel.tsx

ranakan19

left some comments inline

aali309 · 2025-09-11T17:20:07Z

@reggie-k
I see on the issue that we should also hide the panel when AllAtOnce strategy is enabled? It should only show for RollingSync strategy, and user has permissions?

Signed-off-by: Atif Ali <[email protected]>

keithchong

LGTM

keithchong

Merging.

Signed-off-by: Atif Ali <[email protected]>

argo-cd-cherry-pick-bot · 2025-09-18T13:37:48Z

🍒 Cherry-pick PR created for 3.2: #24641

Signed-off-by: Atif Ali <[email protected]>

argo-cd-cherry-pick-bot · 2025-09-18T13:48:53Z

🍒 Cherry-pick PR created for 3.1: #24643

Signed-off-by: Atif Ali <[email protected]>

Signed-off-by: Atif Ali <[email protected]> Co-authored-by: Atif Ali <[email protected]>

aali309 marked this pull request as ready for review August 20, 2025 01:20

aali309 requested a review from a team as a code owner August 20, 2025 01:20

nitishfy reviewed Aug 20, 2025

View reviewed changes

aali309 force-pushed the ProgressiveSyncUnknownInUI branch from d3f364a to aa63630 Compare August 20, 2025 18:28

dag-andersen reviewed Aug 21, 2025

View reviewed changes

aali309 force-pushed the ProgressiveSyncUnknownInUI branch from 577ea25 to 91247cd Compare August 21, 2025 18:13

aali309 force-pushed the ProgressiveSyncUnknownInUI branch from 91247cd to e09721f Compare August 26, 2025 13:31

aali309 force-pushed the ProgressiveSyncUnknownInUI branch from 5777196 to 1451cee Compare September 4, 2025 16:20

ranakan19 reviewed Sep 5, 2025

View reviewed changes

ui/src/app/applications/components/application-status-panel/application-status-panel.tsx Outdated Show resolved Hide resolved

ranakan19 reviewed Sep 5, 2025

View reviewed changes

ui/src/app/applications/components/application-status-panel/application-status-panel.tsx Outdated Show resolved Hide resolved

ranakan19 reviewed Sep 5, 2025

View reviewed changes

aali309 force-pushed the ProgressiveSyncUnknownInUI branch 4 times, most recently from 6235ef9 to 9afdc12 Compare September 9, 2025 20:00

aali309 requested review from dag-andersen and ranakan19 September 15, 2025 17:24

aali309 force-pushed the ProgressiveSyncUnknownInUI branch 2 times, most recently from 710808c to a463e21 Compare September 15, 2025 21:31

aali309 added 10 commits September 17, 2025 11:13

fix: Progress Sync Unknown in UI

500deb2

Signed-off-by: Atif Ali <[email protected]>

resolve linter error

e358bdc

Signed-off-by: Atif Ali <[email protected]>

cleanup

695032f

Signed-off-by: Atif Ali <[email protected]>

renamed hasRollingSyncEnabled to hasApplicationSetParent

d119bd4

Signed-off-by: Atif Ali <[email protected]>

refactor code and apply permission logic to hide the Psync panel

a8751e9

Signed-off-by: Atif Ali <[email protected]>

show panel for all strategies when ProgressiveSync is enabled

cde30d0

Signed-off-by: Atif Ali <[email protected]>

format AllAtOnce progressive sync display

6323fc1

Signed-off-by: Atif Ali <[email protected]>

add dynamic namespace resolution for Progressive Sync panel

f99211d

Signed-off-by: Atif Ali <[email protected]>

check for permissions explicitly using can-i

c2d785b

Signed-off-by: Atif Ali <[email protected]>

disable panel for AllAtOnce strategy

c20ec1d

Signed-off-by: Atif Ali <[email protected]>

aali309 force-pushed the ProgressiveSyncUnknownInUI branch from a463e21 to c20ec1d Compare September 17, 2025 15:14

keithchong reviewed Sep 18, 2025

View reviewed changes

keithchong approved these changes Sep 18, 2025

View reviewed changes

keithchong merged commit fbcaf35 into argoproj:master Sep 18, 2025
24 checks passed

keithchong added the cherry-pick/3.2 Candidate for cherry picking into the 3.2 release branch label Sep 18, 2025

argo-cd-cherry-pick-bot bot pushed a commit that referenced this pull request Sep 18, 2025

fix: Progress Sync Unknown in UI (#24202)

744982f

Signed-off-by: Atif Ali <[email protected]>

argo-cd-cherry-pick-bot bot mentioned this pull request Sep 18, 2025

fix: Progress Sync Unknown in UI (cherry-pick #24202 for 3.2) #24641

Merged

keithchong added the cherry-pick/3.1 Candidate for cherry picking into the 3.1 release branch label Sep 18, 2025

argo-cd-cherry-pick-bot bot pushed a commit that referenced this pull request Sep 18, 2025

fix: Progress Sync Unknown in UI (#24202)

4b243ad

Signed-off-by: Atif Ali <[email protected]>

argo-cd-cherry-pick-bot bot mentioned this pull request Sep 18, 2025

fix: Progress Sync Unknown in UI (cherry-pick #24202 for 3.1) #24643

Merged

aali309 added a commit to aali309/argo-cd that referenced this pull request Sep 18, 2025

fix: Progress Sync Unknown in UI (argoproj#24202)

13d3fef

Signed-off-by: Atif Ali <[email protected]>

jannfis pushed a commit that referenced this pull request Sep 18, 2025

fix: Progress Sync Unknown in UI (cherry-pick #24202 for 3.1) (#24643)

c26cd55

Signed-off-by: Atif Ali <[email protected]> Co-authored-by: Atif Ali <[email protected]>

jannfis pushed a commit that referenced this pull request Sep 18, 2025

fix: Progress Sync Unknown in UI (cherry-pick #24202 for 3.2) (#24641)

1453367

Signed-off-by: Atif Ali <[email protected]> Co-authored-by: Atif Ali <[email protected]>

aali309 deleted the ProgressiveSyncUnknownInUI branch October 16, 2025 17:27

fix: Progress Sync Unknown in UI #24202

fix: Progress Sync Unknown in UI #24202

Uh oh!

Conversation

aali309 commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bunnyshell bot commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment deleted from Bunnyshell

Uh oh!

aali309 commented Aug 20, 2025

Uh oh!

nitishfy left a comment

Choose a reason for hiding this comment

Uh oh!

aali309 commented Aug 20, 2025

Uh oh!

dag-andersen Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

nitishfy commented Aug 21, 2025

Uh oh!

aali309 commented Aug 21, 2025

Uh oh!

aali309 commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reggie-k commented Aug 24, 2025

Uh oh!

aali309 commented Aug 27, 2025

Uh oh!

reggie-k commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aali309 commented Aug 28, 2025

Uh oh!

reggie-k commented Aug 28, 2025

Uh oh!

reggie-k commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aali309 commented Sep 4, 2025

Uh oh!

ranakan19 Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

aali309 Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

reggie-k Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ranakan19 left a comment

Choose a reason for hiding this comment

Uh oh!

aali309 commented Sep 11, 2025

Uh oh!

keithchong left a comment

Choose a reason for hiding this comment

Uh oh!

keithchong left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

argo-cd-cherry-pick-bot bot commented Sep 18, 2025

Uh oh!

argo-cd-cherry-pick-bot bot commented Sep 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

aali309 commented Aug 19, 2025 •

edited

Loading

bunnyshell bot commented Aug 19, 2025 •

edited

Loading

aali309 commented Aug 21, 2025 •

edited

Loading

reggie-k commented Aug 28, 2025 •

edited

Loading

reggie-k commented Aug 28, 2025 •

edited

Loading

keithchong left a comment •

edited

Loading