feat: Add health check for Ceph CRD #24111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment undeployed from BunnyshellAvailable commands (reply to this comment):
|
afarbos
force-pushed
the
af/cephcluster
branch
from
c086b73 to
0108ce0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24111 +/- ##
==========================================
- Coverage 62.29% 62.25% -0.05%
==========================================
Files 351 351
Lines 49213 49213
==========================================
- Hits 30656 30636 -20
- Misses 15640 15652 +12
- Partials 2917 2925 +8 ☔ View full report in Codecov by Sentry. |
afarbos
force-pushed
the
af/cephcluster
branch
from
0108ce0 to
a8e444c
Compare
afarbos
changed the title
afarbos
force-pushed
the
af/cephcluster
branch
2 times, most recently
from
f549a73 to
e227e9e
Compare
crenshaw-dev
added
the
component:health-check
crenshaw-dev
requested changes
Sep 6, 2025
|
|
||
| -- Check state - https://github.com/rook/rook/blob/v1.17.7/pkg/apis/ceph.rook.io/v1/types.go#L621 | ||
| if obj.status.state ~= nil then | ||
| if hs.status == "Healthy" or hs.status == "Connected" then |
There was a problem hiding this comment.
Suggested change
| if hs.status == "Healthy" or hs.status == "Connected" then | |
| if hs.status == "Healthy" then |
I think this was added by mistake. "Connected" isn't a value that's set above, and it's not a valid Argo CD health state.
There was a problem hiding this comment.
Comment addressed in 007b9c3. Thank you for catching this!
afarbos
force-pushed
the
af/cephcluster
branch
from
4b86e0b to
007b9c3
Compare
afarbos
force-pushed
the
af/cephcluster
branch
from
007b9c3 to
3e6dd3f
Compare
|
@crenshaw-dev let me know if there is more I should do. |
afarbos
force-pushed
the
af/cephcluster
branch
2 times, most recently
from
d9f68c6 to
a486b03
Compare
Signed-off-by: Arnaud Farbos <[email protected]>
Signed-off-by: Arnaud Farbos <[email protected]>
Signed-off-by: Arnaud Farbos <[email protected]>
afarbos
force-pushed
the
af/cephcluster
branch
from
a486b03 to
4335156
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supported CRDs:
This is a way to create coverage for ceph rook operator heath.
Checklist: