fix(appset): add applicationset leader election to roles and clean up (#14369) #23976
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,90 +1,77 @@ | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| name: argocd-applicationset-controller | ||
| labels: | ||
| app.kubernetes.io/name: argocd-applicationset-controller | ||
| app.kubernetes.io/part-of: argocd | ||
| app.kubernetes.io/component: applicationset-controller | ||
| rules: | ||
|
Member
Author
There was a problem hiding this comment. Leader election no longer requires config maps - kubernetes-sigs/controller-runtime#1773 |
||
| - apiGroups: | ||
| - argoproj.io | ||
| resources: | ||
| - applications | ||
| - applicationsets | ||
| - applicationsets/finalizers | ||
| verbs: | ||
| - create | ||
| - delete | ||
| - get | ||
| - list | ||
| - patch | ||
| - update | ||
| - watch | ||
| - apiGroups: | ||
| - argoproj.io | ||
| resources: | ||
| - appprojects | ||
| verbs: | ||
| - get | ||
| - list | ||
| - watch | ||
| - apiGroups: | ||
| - argoproj.io | ||
| resources: | ||
| - applicationsets/status | ||
| verbs: | ||
| - get | ||
| - patch | ||
| - update | ||
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - events | ||
| verbs: | ||
| - create | ||
| - get | ||
| - list | ||
| - patch | ||
| - watch | ||
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - secrets | ||
| - configmaps | ||
|
Member
Author
There was a problem hiding this comment. I don't think the applicationset controller needs any config map perms now?
Member
There was a problem hiding this comment. some appset plugin generator still needs access to configmaps eg.
Member
There was a problem hiding this comment. But I don't see any need for write perms in the code too, so this should be fine |
||
| verbs: | ||
| - get | ||
| - list | ||
| - watch | ||
| # argocd-applicationset-controller leader election rules | ||
| # Create with resourceNames fails, so use a separate rule for the lease creation | ||
| - apiGroups: | ||
| - coordination.k8s.io | ||
| resources: | ||
| - leases | ||
| verbs: | ||
| - create | ||
| - apiGroups: | ||
| - coordination.k8s.io | ||
| resources: | ||
| - leases | ||
| resourceNames: | ||
| # Defined in `cmd/argocd-applicationset-controller/commands/applicationset_controller.go` | ||
| - 58ac56fa.applicationsets.argoproj.io | ||
| verbs: | ||
| - get | ||
| - update | ||
| - create | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused why the applicationset controller needs get, list, watch for deployments. I removed it but can add it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I checked these permissions have been there from the very beginning but couldn't find any usage of these perms in the appset code so far.