Skip to content

fix(server): validate new project on update (#23970) #23973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 18, 2025
Merged

fix(server): validate new project on update (#23970) #23973

merged 4 commits into from
Aug 18, 2025

Conversation

@agaudreault
Copy link
Member

@agaudreault agaudreault commented Jul 28, 2025

Closes #23970

@agaudreault
fix(server): validate new project on update
6bd08eb 
Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault
unit tests
3746c44 
Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault agaudreault requested a review from a team as a code owner July 28, 2025 18:08
@bunnyshell
Copy link

bunnyshell bot commented Jul 28, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@agaudreault
error msg missing server by name
3b27b0e 
Signed-off-by: Alexandre Gaudreault <[email protected]>
@codecov
Copy link

codecov bot commented Jul 28, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.11%. Comparing base (fe6aaad) to head (d958428).
⚠️ Report is 264 commits behind head on master.

Files with missing lines Patch % Lines
util/argo/argo.go 47.05% 6 Missing and 3 partials ⚠️
server/application/application.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #23973      +/-   ##
==========================================
- Coverage   60.21%   60.11%   -0.11%     
==========================================
  Files         346      347       +1     
  Lines       59275    59856     +581     
==========================================
+ Hits        35693    35980     +287     
- Misses      20729    20979     +250     
- Partials     2853     2897      +44

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pjiang-dev
pjiang-dev reviewed Aug 12, 2025
View reviewed changes
@agaudreault
add unit tests
d958428 
Signed-off-by: Alexandre Gaudreault <[email protected]>
ishitasequeira
ishitasequeira approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishitasequeira ishitasequeira merged commit 8c8902b into argoproj:master Aug 18, 2025
28 checks passed
Aamir017 pushed a commit to Aamir017/argo-cd that referenced this pull request Aug 21, 2025
@agaudreault @Aamir017
fix(server): validate new project on update (argoproj#23970) (argopro…
5cc342a 
…j#23973)

Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Aamir017 <[email protected]>
adityaraj178 pushed a commit to adityaraj178/argo-cd that referenced this pull request Aug 22, 2025
@agaudreault @adityaraj178
fix(server): validate new project on update (argoproj#23970) (argopro…
7f76c29 
…j#23973)

Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Aditya Raj <[email protected]>
gpamit pushed a commit to gpamit/argo-cd that referenced this pull request Aug 23, 2025
@agaudreault @gpamit
fix(server): validate new project on update (argoproj#23970) (argopro…
34adc34 
…j#23973)

Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Amit Gupta <[email protected]>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
@agaudreault @enneitex
fix(server): validate new project on update (argoproj#23970) (argopro…
dd1cc66 
…j#23973)

Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: enneitex <[email protected]>
downfa11 pushed a commit to downfa11/argo-cd that referenced this pull request Aug 25, 2025
@agaudreault @downfa11
fix(server): validate new project on update (argoproj#23970) (argopro…
9186a07 
…j#23973)

Signed-off-by: Alexandre Gaudreault <[email protected]>
Mangaal pushed a commit to Mangaal/argo-cd that referenced this pull request Sep 10, 2025
@agaudreault @Mangaal
fix(server): validate new project on update (argoproj#23970) (argopro…
76251ee 
…j#23973)

Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Mangaal <[email protected]>
downfa11 pushed a commit to downfa11/argo-cd that referenced this pull request Sep 12, 2025
@agaudreault @downfa11
fix(server): validate new project on update (argoproj#23970) (argopro…
80fa3ca 
…j#23973)

Signed-off-by: Alexandre Gaudreault <[email protected]>
sivasath16 pushed a commit to sivasath16/argo-cd that referenced this pull request Sep 17, 2025
@agaudreault
fix(server): validate new project on update (argoproj#23970) (argopro…
9518c13 
…j#23973)

Signed-off-by: Alexandre Gaudreault <[email protected]>
sivasath16 pushed a commit to sivasath16/argo-cd that referenced this pull request Sep 17, 2025
@agaudreault
fix(server): validate new project on update (argoproj#23970) (argopro…
f17706c 
…j#23973)

Signed-off-by: Alexandre Gaudreault <[email protected]>
@crenshaw-dev crenshaw-dev added cherry-pick/3.0 Candidate for cherry picking into the 3.0 release branch cherry-pick/3.1 Candidate for cherry picking into the 3.1 release branch labels Sep 19, 2025
argo-cd-cherry-pick-bot bot pushed a commit that referenced this pull request Sep 19, 2025
@agaudreault @github-actions
fix(server): validate new project on update (#23970) (#23973)
cf3801c 
Signed-off-by: Alexandre Gaudreault <[email protected]>
argo-cd-cherry-pick-bot bot pushed a commit that referenced this pull request Sep 19, 2025
@agaudreault @github-actions
fix(server): validate new project on update (#23970) (#23973)
b20d01b 
Signed-off-by: Alexandre Gaudreault <[email protected]>
@argo-cd-cherry-pick-bot
Copy link

argo-cd-cherry-pick-bot bot commented Sep 19, 2025

🍒 Cherry-pick PR created for 3.1: #24662

@argo-cd-cherry-pick-bot argo-cd-cherry-pick-bot bot mentioned this pull request Sep 19, 2025
Merged
@argo-cd-cherry-pick-bot
Copy link

argo-cd-cherry-pick-bot bot commented Sep 19, 2025

🍒 Cherry-pick PR created for 3.0: #24663

@argo-cd-cherry-pick-bot argo-cd-cherry-pick-bot bot mentioned this pull request Sep 19, 2025
Merged
crenshaw-dev added a commit that referenced this pull request Sep 19, 2025
@argo-cd-cherry-pick-bot @agaudreault @crenshaw-dev
fix(server): validate new project on update (#23970) (cherry-pick #23973
dcfb4db 
 for 3.0) (#24663)

Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
crenshaw-dev pushed a commit that referenced this pull request Sep 19, 2025
@argo-cd-cherry-pick-bot @agaudreault
fix(server): validate new project on update (#23970) (cherry-pick #23973
4081e29 
 for 3.1) (#24662)

Signed-off-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Alexandre Gaudreault <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

+1 more reviewer

@pjiang-dev pjiang-dev pjiang-dev left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherry-pick/3.0 Candidate for cherry picking into the 3.0 release branch cherry-pick/3.1 Candidate for cherry picking into the 3.1 release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot update the project of an application when previous project is invalid

4 participants

@agaudreault @pjiang-dev @ishitasequeira @crenshaw-dev