-
Notifications
You must be signed in to change notification settings - Fork 6.8k
chore: Add unit test to cover apps health status in an app in any namespace context #23693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
…espace context Signed-off-by: OpenGuidou <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #23693 +/- ##
==========================================
- Coverage 60.22% 60.21% -0.02%
==========================================
Files 346 346
Lines 59197 59202 +5
==========================================
- Hits 35653 35648 -5
- Misses 20686 20689 +3
- Partials 2858 2865 +7 ☔ View full report in Codecov by Sentry. |
aali309
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
crenshaw-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…espace context (argoproj#23693) Signed-off-by: OpenGuidou <[email protected]> Signed-off-by: dsuhinin <[email protected]>
…espace context (argoproj#23693) Signed-off-by: OpenGuidou <[email protected]> Signed-off-by: Manish Kumar <[email protected]>
…espace context (argoproj#23693) Signed-off-by: OpenGuidou <[email protected]> Signed-off-by: enneitex <[email protected]>
…espace context (argoproj#23693) Signed-off-by: OpenGuidou <[email protected]> Signed-off-by: Mangaal <[email protected]>
…espace context (argoproj#23693) Signed-off-by: OpenGuidou <[email protected]>
…espace context (argoproj#23693) Signed-off-by: OpenGuidou <[email protected]>
Adding unit test to cover case fixed in #22944.
Checklist: