fix(repo-server): support .argocd-source.yaml kustomize version (#23643) #23644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…proj#23643) Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
…ize-version Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23644 +/- ##
==========================================
+ Coverage 60.11% 60.19% +0.08%
==========================================
Files 346 346
Lines 59304 59261 -43
==========================================
+ Hits 35650 35675 +25
+ Misses 20783 20729 -54
+ Partials 2871 2857 -14 ☔ View full report in Codecov by Sentry. |
andrii-korotkov
approved these changes
Jul 10, 2025
| type KustomizeVersionNotRegisteredError struct { | ||
| // Version is the Kustomize version that is not registered | ||
| Version string | ||
| } |
Contributor
There was a problem hiding this comment.
Why do we need a dedicated struct for this instead of using an error object for example?
Member
Author
There was a problem hiding this comment.
If you use errors.Is, the error message has to be static. I want to include the version in the error message and still use errors.As, so I have to use a struct with a field.
rumstead
reviewed
Jul 10, 2025
rumstead
reviewed
Jul 10, 2025
Member
|
I left nit picks, otherwise LGTM |
Co-authored-by: rumstead <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: rumstead <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]>
rumstead
approved these changes
Jul 16, 2025
…ize-version Signed-off-by: Michael Crenshaw <[email protected]>
enneitex
pushed a commit
to enneitex/argo-cd
that referenced
this pull request
Aug 24, 2025
…proj#23643) (argoproj#23644) Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: rumstead <[email protected]> Signed-off-by: enneitex <[email protected]>
downfa11
pushed a commit
to downfa11/argo-cd
that referenced
this pull request
Aug 25, 2025
…proj#23643) (argoproj#23644) Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: rumstead <[email protected]>
Mangaal
pushed a commit
to Mangaal/argo-cd
that referenced
this pull request
Sep 10, 2025
…proj#23643) (argoproj#23644) Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: rumstead <[email protected]> Signed-off-by: Mangaal <[email protected]>
downfa11
pushed a commit
to downfa11/argo-cd
that referenced
this pull request
Sep 12, 2025
…proj#23643) (argoproj#23644) Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: rumstead <[email protected]>
sivasath16
pushed a commit
to sivasath16/argo-cd
that referenced
this pull request
Sep 17, 2025
…proj#23643) (argoproj#23644) Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: rumstead <[email protected]>
sivasath16
pushed a commit
to sivasath16/argo-cd
that referenced
this pull request
Sep 17, 2025
…proj#23643) (argoproj#23644) Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: rumstead <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today repo-server clients calculate the desired Kustomize binary path based only on the Application's spec.source field.
But that causes the repo-server to ignore any overrides which are applied via the .argocd-source.yaml file.
This change deprecates the
binaryPathfield in repo-server and changes all internal clients to instead pass a list ofversions. That allows the repo-server to calculate the desired binary path based on the App spec and any .argocd-source.yaml overrides.This change impacts GenerateManifests and GetAppDetails in repo-server, so I've added tests for both.
Fixes #23643