Skip to content

Conversation

@pjiang-dev
Copy link
Contributor

@pjiang-dev pjiang-dev commented Jun 17, 2025

fixes #23436

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@pjiang-dev pjiang-dev requested a review from a team as a code owner June 17, 2025 17:56
@bunnyshell
Copy link

bunnyshell bot commented Jun 17, 2025

❌ Preview Environment undeployed from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz enabled auto-merge (squash) June 17, 2025 17:59
auto-merge was automatically disabled June 18, 2025 17:00

Head branch was pushed to by a user without write access

@pjiang-dev pjiang-dev force-pushed the pjiang/bump-gitops-ssd branch from 79a0db9 to 025a72d Compare June 18, 2025 17:00
@pjiang-dev pjiang-dev force-pushed the pjiang/bump-gitops-ssd branch from 025a72d to 027be5f Compare June 18, 2025 17:36
@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.27%. Comparing base (a671cc9) to head (027be5f).
⚠️ Report is 403 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #23456      +/-   ##
==========================================
+ Coverage   60.25%   60.27%   +0.01%     
==========================================
  Files         343      343              
  Lines       59079    59079              
==========================================
+ Hits        35600    35608       +8     
+ Misses      20611    20606       -5     
+ Partials     2868     2865       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev merged commit f03ffb3 into argoproj:master Jun 18, 2025
28 checks passed
cjcocokrisp pushed a commit to cjcocokrisp/argo-cd that referenced this pull request Jun 24, 2025
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
Mangaal pushed a commit to Mangaal/argo-cd that referenced this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refresh/hydrate annotations show in diff

4 participants