Skip to content

Conversation

@mmorel-35
Copy link
Contributor

Description

Enables and fixes filepathJoin rule from go-critic

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bunnyshell
Copy link

bunnyshell bot commented Jun 17, 2025

❌ Preview Environment undeployed from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@mmorel-35 mmorel-35 force-pushed the go-critic/filepathJoin branch from 98d5115 to 3edf2f6 Compare June 17, 2025 16:43
@mmorel-35 mmorel-35 marked this pull request as ready for review June 17, 2025 16:43
@mmorel-35 mmorel-35 requested a review from a team as a code owner June 17, 2025 16:43
@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.14%. Comparing base (fa25f27) to head (3edf2f6).
⚠️ Report is 409 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #23453      +/-   ##
==========================================
- Coverage   60.21%   60.14%   -0.08%     
==========================================
  Files         343      343              
  Lines       59047    59047              
==========================================
- Hits        35553    35511      -42     
- Misses      20645    20677      +32     
- Partials     2849     2859      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev merged commit 8b25604 into argoproj:master Jun 17, 2025
28 checks passed
@mmorel-35 mmorel-35 deleted the go-critic/filepathJoin branch June 17, 2025 17:44
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
Mangaal pushed a commit to Mangaal/argo-cd that referenced this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants