Skip to content

chore(lint): enable-all govet rules by default #23426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

chore(lint): enable-all govet rules by default #23426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,11 @@ issues:

linters:
enable:
- exptostd
- errorlint
- exptostd
- gocritic
- gomodguard
- govet
- importas
- misspell
- perfsprint
Expand Down Expand Up @@ -88,6 +89,12 @@ linters:
recommendations:
- errors

govet:
disable:
- fieldalignment
- shadow
enable-all: true

importas:
alias:
- pkg: github.com/golang-jwt/jwt/v5
Expand Down
38 changes: 18 additions & 20 deletions reposerver/repository/repository_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3244,8 +3244,7 @@ func Test_populateHelmAppDetails_values_symlinks(t *testing.T) {
}

func TestGetHelmRepos_OCIHelmDependenciesWithHelmRepo(t *testing.T) {
src := v1alpha1.ApplicationSource{Path: "."}
q := apiclient.ManifestRequest{Repos: []*v1alpha1.Repository{}, ApplicationSource: &src, HelmRepoCreds: []*v1alpha1.RepoCreds{
q := apiclient.ManifestRequest{Repos: []*v1alpha1.Repository{}, HelmRepoCreds: []*v1alpha1.RepoCreds{
{URL: "example.com", Username: "test", Password: "test", EnableOCI: true},
}}

Expand All @@ -3259,8 +3258,7 @@ func TestGetHelmRepos_OCIHelmDependenciesWithHelmRepo(t *testing.T) {
}

func TestGetHelmRepos_OCIHelmDependenciesWithRepo(t *testing.T) {
src := v1alpha1.ApplicationSource{Path: "."}
q := apiclient.ManifestRequest{Repos: []*v1alpha1.Repository{{Repo: "example.com", Username: "test", Password: "test", EnableOCI: true}}, ApplicationSource: &src, HelmRepoCreds: []*v1alpha1.RepoCreds{}}
q := apiclient.ManifestRequest{Repos: []*v1alpha1.Repository{{Repo: "example.com", Username: "test", Password: "test", EnableOCI: true}}, HelmRepoCreds: []*v1alpha1.RepoCreds{}}

helmRepos, err := getHelmRepos("./testdata/oci-dependencies", q.Repos, q.HelmRepoCreds)
require.NoError(t, err)
Expand All @@ -3272,8 +3270,7 @@ func TestGetHelmRepos_OCIHelmDependenciesWithRepo(t *testing.T) {
}

func TestGetHelmRepos_OCIDependenciesWithHelmRepo(t *testing.T) {
src := v1alpha1.ApplicationSource{Path: "."}
q := apiclient.ManifestRequest{Repos: []*v1alpha1.Repository{}, ApplicationSource: &src, HelmRepoCreds: []*v1alpha1.RepoCreds{
q := apiclient.ManifestRequest{Repos: []*v1alpha1.Repository{}, HelmRepoCreds: []*v1alpha1.RepoCreds{
{URL: "oci://example.com", Username: "test", Password: "test", Type: "oci"},
}}

Expand All @@ -3287,8 +3284,7 @@ func TestGetHelmRepos_OCIDependenciesWithHelmRepo(t *testing.T) {
}

func TestGetHelmRepos_OCIDependenciesWithRepo(t *testing.T) {
src := v1alpha1.ApplicationSource{Path: "."}
q := apiclient.ManifestRequest{Repos: []*v1alpha1.Repository{{Repo: "oci://example.com", Username: "test", Password: "test", Type: "oci"}}, ApplicationSource: &src, HelmRepoCreds: []*v1alpha1.RepoCreds{}}
q := apiclient.ManifestRequest{Repos: []*v1alpha1.Repository{{Repo: "oci://example.com", Username: "test", Password: "test", Type: "oci"}}, HelmRepoCreds: []*v1alpha1.RepoCreds{}}

helmRepos, err := getHelmRepos("./testdata/oci-dependencies", q.Repos, q.HelmRepoCreds)
require.NoError(t, err)
Expand All @@ -3300,12 +3296,13 @@ func TestGetHelmRepos_OCIDependenciesWithRepo(t *testing.T) {
}

func TestGetHelmRepo_NamedRepos(t *testing.T) {
src := v1alpha1.ApplicationSource{Path: "."}
q := apiclient.ManifestRequest{Repo: &v1alpha1.Repository{}, ApplicationSource: &src, Repos: []*v1alpha1.Repository{{
Name: "custom-repo",
Repo: "https://example.com",
Username: "test",
}}}
q := apiclient.ManifestRequest{
Repos: []*v1alpha1.Repository{{
Name: "custom-repo",
Repo: "https://example.com",
Username: "test",
}},
}

helmRepos, err := getHelmRepos("./testdata/helm-with-dependencies", q.Repos, q.HelmRepoCreds)
require.NoError(t, err)
Expand All @@ -3316,12 +3313,13 @@ func TestGetHelmRepo_NamedRepos(t *testing.T) {
}

func TestGetHelmRepo_NamedReposAlias(t *testing.T) {
src := v1alpha1.ApplicationSource{Path: "."}
q := apiclient.ManifestRequest{Repo: &v1alpha1.Repository{}, ApplicationSource: &src, Repos: []*v1alpha1.Repository{{
Name: "custom-repo-alias",
Repo: "https://example.com",
Username: "test-alias",
}}}
q := apiclient.ManifestRequest{
Repos: []*v1alpha1.Repository{{
Name: "custom-repo-alias",
Repo: "https://example.com",
Username: "test-alias",
}},
}

helmRepos, err := getHelmRepos("./testdata/helm-with-dependencies-alias", q.Repos, q.HelmRepoCreds)
require.NoError(t, err)
Expand Down
Loading