chore(lint): enable emptyStringTest rule from go-critic

[mmorel-35]

Description

Enables and fixes emptyStringTest rule from go-critic

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[codecov]

Codecov Report

❌ Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.11%. Comparing base (2801a11) to head (65b2c0d).
⚠️ Report is 429 commits behind head on master.

Files with missing lines	Patch %	Lines
controller/cache/info.go	0.00%	2 Missing ⚠️
server/server.go	0.00%	0 Missing and 2 partials ⚠️
applicationset/services/internal/http/client.go	0.00%	0 Missing and 1 partial ⚠️
cmd/argocd/commands/cluster.go	0.00%	1 Missing ⚠️
cmd/argocd/commands/plugin.go	0.00%	0 Missing and 1 partial ⚠️
cmd/util/app.go	0.00%	0 Missing and 1 partial ⚠️
pkg/apis/application/v1alpha1/types.go	80.00%	0 Missing and 1 partial ⚠️
server/application/application.go	0.00%	1 Missing ⚠️
util/kube/portforwarder.go	0.00%	1 Missing ⚠️
util/templates/normalizers.go	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #23400      +/-   ##
==========================================
+ Coverage   60.07%   60.11%   +0.04%     
==========================================
  Files         342      342              
  Lines       58814    58814              
==========================================
+ Hits        35330    35356      +26     
+ Misses      20623    20599      -24     
+ Partials     2861     2859       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.