chore(lint): enable typeSwitchVar linter #23391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
crenshaw-dev
commented
Jun 13, 2025
Comment on lines
+1419
to
+1423
| switch segment := segment.(type) { | ||
| case int: | ||
| i = i.([]any)[segment.(int)] | ||
| i = i.([]any)[segment] | ||
| case string: | ||
| i = i.(map[string]any)[segment.(string)] | ||
| i = i.(map[string]any)[segment] |
There was a problem hiding this comment.
These three lines are what the linter required.
crenshaw-dev
commented
Jun 13, 2025
| } | ||
|
|
||
| func dig[T any](obj any, path []any) T { | ||
| func dig(obj any, path ...any) any { |
There was a problem hiding this comment.
Got rid of generics (not needed) and replaced slice w/ nicer alternative.
Signed-off-by: Michael Crenshaw <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #23391 +/- ##
==========================================
- Coverage 60.10% 60.05% -0.06%
==========================================
Files 342 342
Lines 58820 58820
==========================================
- Hits 35353 35323 -30
- Misses 20623 20641 +18
- Partials 2844 2856 +12 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Crenshaw <[email protected]>
rumstead
approved these changes
Jun 16, 2025
nitishfy
approved these changes
Jun 16, 2025
Signed-off-by: Michael Crenshaw <[email protected]>
jcogilvie
pushed a commit
to Sanyaku/argo-cd
that referenced
this pull request
Jun 16, 2025
Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Jonathan Ogilvie <[email protected]>
enneitex
pushed a commit
to enneitex/argo-cd
that referenced
this pull request
Aug 24, 2025
Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: enneitex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the liberty of simplifying the dig function even more than required to fix the lint.