fix(test): race condition in kubectl metrics (#23382) #23383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
blakepettersson
approved these changes
Jun 13, 2025
rumstead
approved these changes
Jun 13, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #23383 +/- ##
==========================================
- Coverage 60.00% 59.89% -0.12%
==========================================
Files 342 342
Lines 58619 58605 -14
==========================================
- Hits 35176 35102 -74
- Misses 20598 20644 +46
- Partials 2845 2859 +14 ☔ View full report in Codecov by Sentry. |
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
…oj#23383) Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: dsuhinin <[email protected]>
jcogilvie
pushed a commit
to Sanyaku/argo-cd
that referenced
this pull request
Jun 16, 2025
…oj#23383) Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Jonathan Ogilvie <[email protected]>
enneitex
pushed a commit
to enneitex/argo-cd
that referenced
this pull request
Aug 24, 2025
…oj#23383) Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: enneitex <[email protected]>
agaudreault
pushed a commit
to agaudreault/argo-cd
that referenced
this pull request
Sep 5, 2025
…oj#23383) Signed-off-by: Michael Crenshaw <[email protected]>
agaudreault
added a commit
that referenced
this pull request
Sep 5, 2025
Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
leoluz
reviewed
Sep 5, 2025
| func Test_RegisterWithClientGo_race(_ *testing.T) { | ||
| // This test ensures that the RegisterWithClientGo function can be called concurrently without causing a data race. | ||
| go RegisterWithClientGo() | ||
| go RegisterWithClientGo() |
There was a problem hiding this comment.
As the test doesn't have any assertion, the 2 goroutines will be terminated as soon as it triggers the second one. Maybe we should somehow add an assertion to make sure both goroutines are executed to the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My initial implementation was overly complicated, because I thought I needed a
initiatorfield on the metrics struct.Instead, I can just deal directly with global variables.
This test refactors for simplicity and protects the global var initialization with a sync.Once.
Closes #23382