Skip to content

Conversation

@chengfang
Copy link
Contributor

This PR fixes the example cli commands in argocd admin repo command, and the description of tls-client-cert-key-path flag. Re-generated all relevent docs *.md files.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@chengfang chengfang requested review from a team as code owners June 12, 2025 19:27
@bunnyshell
Copy link

bunnyshell bot commented Jun 12, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix the failing tests?

@chengfang
Copy link
Contributor Author

The "image/build-only/publish" job failed due to yarn install failure, which I've seen also present in other PRs, and seems to be environmental:

Error: buildx failed with: ERROR: failed to solve: process "/bin/sh -c yarn install --network-timeout 200000 &&     yarn cache clean" did not complete successfully: exit code: 1

The other "Integration tests" jobs failed due to failure to install k3s to /etc/rancher/k3s, and also looks environmental.

Can we restart these failed jobs?

@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@fd48c47). Learn more about missing BASE report.
⚠️ Report is 428 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/admin/repo.go 0.00% 3 Missing ⚠️
cmd/util/repo.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #23375   +/-   ##
=========================================
  Coverage          ?   60.10%           
=========================================
  Files             ?      342           
  Lines             ?    58816           
  Branches          ?        0           
=========================================
  Hits              ?    35351           
  Misses            ?    20614           
  Partials          ?     2851           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishitasequeira ishitasequeira merged commit 25fc5d2 into argoproj:master Jun 17, 2025
28 checks passed
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
Mangaal pushed a commit to Mangaal/argo-cd that referenced this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants