Skip to content

Conversation

@pjiang-dev
Copy link
Contributor

@pjiang-dev pjiang-dev commented Jun 9, 2025

fixes #23214
gitops-engine PR: argoproj/gitops-engine#727 - This needs to be merged first

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bunnyshell
Copy link

bunnyshell bot commented Jun 9, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@pjiang-dev pjiang-dev marked this pull request as ready for review June 11, 2025 20:52
@pjiang-dev pjiang-dev requested a review from a team as a code owner June 11, 2025 20:52
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add documentation about the following:

Technical doc about:
The new sync option
The feature flag

User/Migration doc about describing about the feature, why it is needed and how to use it. We could add a reference to kubernetes doc too: https://github.com/alexzielenski/enhancements/blob/03df8820b9feca6d2cab78e303c99b2[…]keps/sig-cli/3517-kubectl-client-side-apply-migration/README.md

@pjiang-dev pjiang-dev requested a review from a team as a code owner June 12, 2025 23:51
@pjiang-dev pjiang-dev requested a review from leoluz June 13, 2025 00:04
Signed-off-by: Peter Jiang <[email protected]>
Signed-off-by: Peter Jiang <[email protected]>
Signed-off-by: Peter Jiang <[email protected]>
Signed-off-by: Peter Jiang <[email protected]>
Signed-off-by: Peter Jiang <[email protected]>
Signed-off-by: Peter Jiang <[email protected]>
@pjiang-dev pjiang-dev force-pushed the pjiang/SSA-CSA-migration branch from b0570d1 to 1d5a48a Compare June 13, 2025 17:16
Signed-off-by: Peter Jiang <[email protected]>
@codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@1df47e9). Learn more about missing BASE report.
⚠️ Report is 418 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #23337   +/-   ##
=========================================
  Coverage          ?   60.08%           
=========================================
  Files             ?      342           
  Lines             ?    58814           
  Branches          ?        0           
=========================================
  Hits              ?    35337           
  Misses            ?    20612           
  Partials          ?     2865           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments.

Signed-off-by: Peter Jiang <[email protected]>
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz enabled auto-merge (squash) June 13, 2025 21:23
@leoluz leoluz merged commit dc1d148 into argoproj:master Jun 13, 2025
27 checks passed
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
Signed-off-by: Peter Jiang <[email protected]>
Signed-off-by: Peter Jiang <[email protected]>
Signed-off-by: dsuhinin <[email protected]>
@agaudreault agaudreault added for-release-blog-3-1 PR that should be highlighted in the Release Blog labels Jun 16, 2025
jcogilvie pushed a commit to Sanyaku/argo-cd that referenced this pull request Jun 16, 2025
Signed-off-by: Peter Jiang <[email protected]>
Signed-off-by: Peter Jiang <[email protected]>
Signed-off-by: Jonathan Ogilvie <[email protected]>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
Signed-off-by: Peter Jiang <[email protected]>
Signed-off-by: Peter Jiang <[email protected]>
Signed-off-by: enneitex <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

for-release-blog-3-1 PR that should be highlighted in the Release Blog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server-Side Apply prevents field deletion owned by other managers

3 participants