fix(server): race condition in revoked token logic (#23311) #23312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #23312 +/- ##
=======================================
Coverage 59.93% 59.93%
=======================================
Files 342 342
Lines 58573 58573
=======================================
+ Hits 35105 35106 +1
- Misses 20620 20623 +3
+ Partials 2848 2844 -4 ☔ View full report in Codecov by Sentry. |
rumstead
approved these changes
Jun 6, 2025
philippemerle
pushed a commit
to philippemerle/argoproj-argo-cd
that referenced
this pull request
Jun 7, 2025
…rgoproj#23312) Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Philippe Merle <[email protected]>
philippemerle
pushed a commit
to philippemerle/argoproj-argo-cd
that referenced
this pull request
Jun 7, 2025
…rgoproj#23312) Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Philippe Merle <[email protected]>
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
…rgoproj#23312) Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: dsuhinin <[email protected]>
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
…rgoproj#23312) Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: dsuhinin <[email protected]>
enneitex
pushed a commit
to enneitex/argo-cd
that referenced
this pull request
Aug 24, 2025
…rgoproj#23312) Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: enneitex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23311
Reproduced this by adding a 100x loop to TestGracefulShutdown, but I reverted that to avoid slow tests.
I considered expanding the lock in
loadRevokedTokensto include the Redis Scan call. But that would be a significant performance downside for something that's easily solved by just doing things in the correct order.